-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[Bugfix] Initialize attention bias on the same device as Query/Key/Value for QwenVL Series #14031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lue for Qwen2VL Series The same issue as `https://github.com/vllm-project/vllm/pull/13468` for QwenVL Series in vllm GRPOTrainer
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Can you please address the pre-commit linting errors? |
Fix linting
Fix linting problem.
quick fix linting
quick fix linting
…lue for QwenVL Series (vllm-project#14031)
…lue for QwenVL Series (vllm-project#14031) Signed-off-by: Louis Ulmer <[email protected]>
…lue for QwenVL Series (vllm-project#14031)
Similar issue as #13468 where the attention bias in vLLM's xformers backend is currently initialized on the default device, rather than the device of the Q/K/V tensors.
The #13468 workaround doesn't quite solve the problem for QwenVL series when vLLM is used in conjunction with libraries like trl for GRPO training.
The cuda device mismatched issue still exists for xformer backend.
[rank0]: ValueError: Attention bias and Query/Key/Value should be on the same deviceThis PR solve cuda device mismatch problem for QwenVL Series