[Bugfix] Modify modelscope api usage in transformer_utils #13807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shanshan Shen <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Isotr0py
approved these changes
Feb 25, 2025
github-actions
bot
added
the
ready
Contributor
|
For those who might care: Please update your modelscope with |
Akshat-Tripathi
pushed a commit
to krai/vllm
that referenced
this pull request
Mar 3, 2025
This was referenced Mar 7, 2025
wangxiyuan
pushed a commit
to vllm-project/vllm-ascend
that referenced
this pull request
Mar 9, 2025
### What this PR does / why we need it? Pin modelscope<1.23.0 on vLLM v0.7.3 to resolve: vllm-project/vllm#13807 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <[email protected]>
wangxiyuan
pushed a commit
to vllm-project/vllm-ascend
that referenced
this pull request
Mar 9, 2025
### What this PR does / why we need it? Pin modelscope<1.23.0 on vLLM v0.7.3 to resolve: vllm-project/vllm#13807 Backport: #272 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <[email protected]>
wangxiyuan
pushed a commit
to vllm-project/vllm-ascend
that referenced
this pull request
Mar 11, 2025
### What this PR does / why we need it? Pin modelscope<1.23.0 match vLLM 0.7.3 vllm-project/vllm#13807 is not included in v0.7.3, thus we just pin it to branch v0.7.3-dev ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with existing test. Signed-off-by: MengqingCao <[email protected]>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Mar 18, 2025
### What this PR does / why we need it? Pin modelscope<1.23.0 on vLLM v0.7.3 to resolve: vllm-project/vllm#13807 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: angazenn <[email protected]>
wangxiyuan
pushed a commit
to vllm-project/vllm-ascend
that referenced
this pull request
Mar 26, 2025
### What this PR does / why we need it? Add support for V1 Engine on v0.7.3. ### Does this PR introduce _any_ user-facing change? Find more details at #295. Plus, due to a bug of `vllm v0.7.3` when using modelscope, you should use a lower version of `modelscope`. Find more details at vllm-project/vllm#13807. This can work: ```bash pip install modelscope==1.21.1 ``` ### How was this patch tested? Find more details at #295. Signed-off-by: shen-shanshan <[email protected]> Co-authored-by: didongli182 <[email protected]>
Collaborator
|
This issue resolved since v0.8.0, for vLLM v0.7.3： |
lulmer
pushed a commit
to lulmer/vllm
that referenced
this pull request
Apr 7, 2025
…ct#13807) Signed-off-by: Louis Ulmer <[email protected]>
ttanzhiqiang
pushed a commit
to ttanzhiqiang/vllm-ascend
that referenced
this pull request
Apr 27, 2025
### What this PR does / why we need it? Pin modelscope<1.23.0 on vLLM v0.7.3 to resolve: vllm-project/vllm#13807 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <[email protected]>
shreyankg
pushed a commit
to shreyankg/vllm
that referenced
this pull request
May 3, 2025
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? Pin modelscope<1.23.0 on vLLM v0.7.3 to resolve: vllm-project/vllm#13807 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
Modify modelscope api usage in
transformer_utils.Find more details at this issue in modelscope.
This
_try_login()has been removed, now you just need code below:If token is None, this method will not throw, if token is not correct, this method will throw an error.
This is easier to use.