Skip to content

[BugFix] Minor: logger import in attention backend #13706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2025
Merged

[BugFix] Minor: logger import in attention backend #13706

merged 1 commit into from
Feb 23, 2025

Conversation

@andylolu2
Copy link
Contributor

@andylolu2 andylolu2 commented Feb 22, 2025 •
edited
Loading

vllm/attention/backends/utils.py is not using the logger from vllm.logger.init_logger

@github-actions
Copy link

github-actions bot commented Feb 22, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@andylolu2 andylolu2 changed the title Fix logger in attention backend [Bugfix] Fix logger in attention backend Feb 22, 2025
@andylolu2 andylolu2 changed the title [Bugfix] Fix logger in attention backend [BugFix] logger import in attention backend Feb 22, 2025
@andylolu2 andylolu2 force-pushed the fix-logging-attention branch from 8446602 to 91a4921 Compare February 22, 2025 18:53
@andylolu2 andylolu2 changed the title [BugFix] logger import in attention backend [BugFix] Minor: logger import in attention backend Feb 22, 2025
@WoosukKwon WoosukKwon merged commit 322d2a2 into vllm-project:main Feb 23, 2025
18 of 19 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@andylolu2 @Akshat-Tripathi
[BugFix] Minor: logger import in attention backend (vllm-project#13706)
e5ad78f 
Signed-off-by: Andy Lo <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@andylolu2 @lulmer
[BugFix] Minor: logger import in attention backend (vllm-project#13706)
1737301 
Signed-off-by: Andy Lo <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@andylolu2 @shreyankg
[BugFix] Minor: logger import in attention backend (vllm-project#13706)
ca41ee8 
Signed-off-by: Andy Lo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comaniac comaniac comaniac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andylolu2 @comaniac @WoosukKwon