File tree Expand file tree Collapse file tree 4 files changed +0
-11
lines changed
Expand file tree Collapse file tree 4 files changed +0
-11
lines changed Original file line number Diff line number Diff line change @@ -225,8 +225,6 @@ def __init__(
225225 # Logic to switch between engines is done at runtime instead of import
226226 # to avoid import order issues
227227 self .engine_class = self .get_engine_class ()
228-
229- # TODO(rob): enable mp by default (issue with fork vs spawn)
230228 self .llm_engine = self .engine_class .from_engine_args (
231229 engine_args , usage_context = UsageContext .LLM_CLASS )
232230
Original file line number Diff line number Diff line change @@ -94,8 +94,6 @@ class InprocClient(EngineCoreClient):
9494
9595 * pushes EngineCoreRequest directly into the EngineCore
9696 * pulls EngineCoreOutputs by stepping the EngineCore
97-
98- TODO: support asyncio-mode for debugging.
9997 """
10098
10199 def __init__ (self , * args , ** kwargs ):
Original file line number Diff line number Diff line change @@ -42,8 +42,6 @@ def __init__(
4242 use_cached_outputs : bool = False ,
4343 multiprocess_mode : bool = False ,
4444 ) -> None :
45-
46- # TODO: Can we avoid this?
4745 self .model_config = vllm_config .model_config
4846
4947 # Tokenizer (+ ensure liveness if running in another process).
@@ -179,8 +177,6 @@ def step(self) -> List[RequestOutput]:
179177
180178 return request_outputs
181179
182- # TODO(rob): Can we get rid of these?
183-
184180 def get_model_config (self ):
185181 return self .model_config
186182
Original file line number Diff line number Diff line change @@ -49,9 +49,6 @@ def __init__(
4949 cache_config .enable_prefix_caching
5050 self .mm_hasher = MMHasher ()
5151
52- # TODO: run in an ThreadpoolExecutor or BackgroundProcess.
53- # This ideally should releases the GIL, so we should not block the
54- # asyncio loop while this is running.
5552 def process_inputs (
5653 self ,
5754 request_id : str ,
You can’t perform that action at this time.
0 commit comments