Missing comment explaining VDR variable in GGUF kernels (#13290)

SzymonOzog · web-flow · commit 1cdc88614a1c · 2025-02-20T22:06:54.000-08:00
diff --git a/csrc/quantization/gguf/vecdotq.cuh b/csrc/quantization/gguf/vecdotq.cuh
@@ -37,6 +37,8 @@ static __device__ __forceinline__ int get_int_from_uint8_aligned(const uint8_t *
     return *((const int *) (x8 + sizeof(int) * i32)); // assume at least 4 byte alignment
 }
 
+// VDR = vec dot ratio, how many contiguous integers each thread processes when the vec dot kernel is called
+// MMVQ = mul_mat_vec_q, MMQ = mul_mat_q
 
 #define VDR_Q4_0_Q8_1_MMVQ 2
 #define VDR_Q4_0_Q8_1_MMQ  4

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@ static __device__ __forceinline__ int get_int_from_uint8_aligned(const uint8_t *`
`37`	`37`	`return ((const int ) (x8 + sizeof(int) * i32)); // assume at least 4 byte alignment`
`38`	`38`	`}`
`39`	`39`
	`40`	`+// VDR = vec dot ratio, how many contiguous integers each thread processes when the vec dot kernel is called`
	`41`	`+// MMVQ = mul_mat_vec_q, MMQ = mul_mat_q`
`40`	`42`
`41`	`43`	`#define VDR_Q4_0_Q8_1_MMVQ 2`
`42`	`44`	`#define VDR_Q4_0_Q8_1_MMQ 4`