Skip to content

Commit 25e0fd5

Browse files
committed
Fix failing settings tests
Signed-off-by: Samuel Monson <[email protected]>
1 parent 38f1738 commit 25e0fd5

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

tests/unit/test_settings.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,16 @@
1212
settings,
1313
)
1414

15+
BASE_URL = "https://blog.vllm.ai/guidellm/ui/"
16+
1517

1618
@pytest.mark.smoke
1719
def test_default_settings():
1820
settings = Settings()
1921
assert settings.env == Environment.PROD
2022
assert settings.logging == LoggingSettings()
2123
assert settings.openai == OpenAISettings()
22-
assert (
23-
settings.report_generation.source
24-
== "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html"
25-
)
24+
assert settings.report_generation.source.startswith(BASE_URL)
2625

2726

2827
@pytest.mark.smoke
@@ -58,16 +57,10 @@ def test_report_generation_default_source():
5857
)
5958

6059
settings = Settings(env=Environment.STAGING)
61-
assert (
62-
settings.report_generation.source
63-
== "https://blog.vllm.ai/guidellm/ui/release/v0.3.0/index.html"
64-
)
60+
assert settings.report_generation.source.startswith(BASE_URL)
6561

6662
settings = Settings(env=Environment.PROD)
67-
assert (
68-
settings.report_generation.source
69-
== "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html"
70-
)
63+
assert settings.report_generation.source.startswith(BASE_URL)
7164

7265

7366
@pytest.mark.sanity

0 commit comments

Comments
 (0)