Add ability to use tunneling at story level #5890
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
uarlouski
force-pushed
the
tunnel-per-story
branch
from
62a6d10 to
3ac28dc
Compare
uarlouski
force-pushed
the
tunnel-per-story
branch
from
3ac28dc to
e2afe28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5890 +/- ##
============================================
- Coverage 97.73% 97.73% -0.01%
- Complexity 7226 7472 +246
============================================
Files 996 996
Lines 20993 20998 +5
Branches 1381 1381
============================================
+ Hits 20518 20522 +4
Misses 364 364
- Partials 111 112 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
uarlouski
force-pushed
the
tunnel-per-story
branch
from
e2afe28 to
0b2ceab
Compare
|
valfirst
requested changes
Jun 4, 2025
Comment on lines
+92
to
+94
| a|Enables https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy[Sauce Connect Proxy] | ||
|
|
||
| The https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy[Sauce Connect Proxy] can also be enabled at story level by using `@tunnel` meta tag. |
Collaborator
There was a problem hiding this comment.
Suggested change
| a|Enables https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy[Sauce Connect Proxy] | |
| The https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy[Sauce Connect Proxy] can also be enabled at story level by using `@tunnel` meta tag. | |
| a|Enables https://docs.saucelabs.com/secure-connections/[Sauce Connect Proxy] | |
| https://docs.saucelabs.com/secure-connections/[Sauce Connect Proxy] can also be enabled at story level by using `@tunnel` meta tag. |
| getRunningStory().map(RunningStory::getName).ifPresent(testNameConsumer); | ||
| } | ||
|
|
||
| protected Optional<RunningStory> getRunningStory() |
Collaborator
There was a problem hiding this comment.
Suggested change
| protected Optional<RunningStory> getRunningStory() | |
| private Optional<RunningStory> getRunningStory() |
| protected abstract void setCapability(DesiredCapabilities capabilities, Meta meta); | ||
| protected void setCapability(DesiredCapabilities capabilities, Meta meta) | ||
| { | ||
| // Nothing to do |
Collaborator
There was a problem hiding this comment.
not a good default implementation, it's better to keep empty methods per enum entry
| public void configure(DesiredCapabilities desiredCapabilities) | ||
| { | ||
| Validate.isTrue(!hasControllingMetaTag(ControllingMetaTag.TUNNEL), | ||
| "ExecutionCloud doesn't support tunneling capabilities."); |
Collaborator
There was a problem hiding this comment.
Suggested change
| "ExecutionCloud doesn't support tunneling capabilities."); | |
| "ExecutionCloud does not support tunnelling"); |
Comment on lines
+35
to
+36
| Validate.isTrue(!hasControllingMetaTag(ControllingMetaTag.TUNNEL), | ||
| "LambdaTest doesn't support tunneling capabilities."); |
Collaborator
There was a problem hiding this comment.
Suggested change
| Validate.isTrue(!hasControllingMetaTag(ControllingMetaTag.TUNNEL), | |
| "LambdaTest doesn't support tunneling capabilities."); | |
| Validate.isTrue(!hasControllingMetaTag(ControllingMetaTag.TUNNEL), | |
| "LambdaTest does not support tunnelling"); |
| for profile in "${profiles[@]}"; do | ||
| ./gradlew :vividus-tests:debugStories -Pvividus.configuration.environments=system/saucelabs \ | ||
| -Pvividus.configuration.suites=health_check \ | ||
| -Pvividus.configuration.suites=health_check/extended \ |
Collaborator
There was a problem hiding this comment.
no reason to check if tunnelling works for each browser, it's enough to have one browser only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.