Skip to content

Conversation

@draker94
Copy link
Contributor

No description provided.

@draker94 draker94 requested a review from a team as a code owner December 13, 2024 07:46

public class PropertyMapper implements IPropertyMapper
{
private static final String VARIABLES_PROPERTY_PREFIX = "variables.";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't hardcode it here:

  1. util module should know nothing about engine module
  2. this adds tight coupling to property naming

please check this: c9197ca

@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (d708d84) to head (5317cad).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #5597    +/-   ##
==========================================
  Coverage     97.69%   97.70%            
- Complexity     7073     7124    +51     
==========================================
  Files           984      987     +3     
  Lines         20536    20662   +126     
  Branches       1344     1353     +9     
==========================================
+ Hits          20063    20188   +125     
- Misses          361      363     +2     
+ Partials        112      111     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants