[config show]BGP Suppress fib pending config and display for multi-asic (sonic-net#3948)

CLI commands part of the fix for issue (sonic-net#19022)

How I did it
To send the suppress-fib-pending configuration to all asics in multi-asic system
Show command to diplay current suppress-fib-pending configuration for all available asics
Unit tests to test the multi-asic support of suppress-fib-pending configuration
---------

Signed-off-by: vedganes <[email protected]>

Author: vganesan-nokia

config/main.py

@@ -2572,8 +2572,15 @@ def suppress_pending_fib(db, state):
     ''' Enable or disable pending FIB suppression. Once enabled,
         BGP will not advertise routes that are not yet installed in the hardware '''
 
-    config_db = db.cfgdb
-    config_db.mod_entry('DEVICE_METADATA', 'localhost', {"suppress-fib-pending": state})
+    namespace_list = [multi_asic.DEFAULT_NAMESPACE]
+
+    # For multi-asic system apply configuration to all asics
+    if multi_asic.get_num_asics() > 1:
+        namespace_list = multi_asic.get_namespaces_from_linux()
+
+    for ns in namespace_list:
+        config_db = db.cfgdb_clients[ns]
+        config_db.mod_entry('DEVICE_METADATA', 'localhost', {"suppress-fib-pending": state})
 
 #
 # 'yang_config_validation' command ('config yang_config_validation ...')

show/main.py

@@ -33,7 +33,6 @@
     if os.environ["UTILITIES_UNIT_TESTING_TOPOLOGY"] == "multi_asic":
         import mock_tables.mock_multi_asic
         reload(mock_tables.mock_multi_asic)
-        reload(mock_tables.dbconnector)
         mock_tables.dbconnector.load_namespace_config()
 
 except KeyError:
@@ -2697,9 +2696,22 @@ def peer(db, peer_ip, namespace):
 def suppress_pending_fib(db):
     """ Show the status of suppress pending FIB feature """
 
-    field_values = db.cfgdb.get_entry('DEVICE_METADATA', 'localhost')
-    state = field_values.get('suppress-fib-pending', 'disabled').title()
-    click.echo(state)
+    if multi_asic.get_num_asics() > 1:
+        namespace_list = multi_asic.get_namespaces_from_linux()
+        masic = True
+    else:
+        namespace_list = [multi_asic.DEFAULT_NAMESPACE]
+        masic = False
+
+    for ns in namespace_list:
+        config_db = db.cfgdb_clients[ns]
+        field_values = config_db.get_entry('DEVICE_METADATA', 'localhost')
+        state = field_values.get('suppress-fib-pending', 'enabled').title()
+
+        if masic:
+            click.echo("{}: {}".format(ns, state))
+        else:
+            click.echo("{}".format(state))
 
 
 # asic-sdk-health-event subcommand ("show asic-sdk-health-event")

tests/suppress_pending_fib_test.py

@@ -1,3 +1,5 @@
+import os
+import importlib
 from click.testing import CliRunner
 
 import config.main as config
@@ -32,3 +34,59 @@ def test_synchronous_mode(self):
         result = runner.invoke(config.config.commands['suppress-fib-pending'], ['invalid-input'], obj=db)
         print(result.output)
         assert result.exit_code != 0
+
+
+class TestSuppressFibPendingMultiAsic(object):
+    @classmethod
+    def setup_class(cls):
+        print("SETUP")
+        os.environ["UTILITIES_UNIT_TESTING"] = "2"
+        os.environ["UTILITIES_UNIT_TESTING_TOPOLOGY"] = "multi_asic"
+        import show.main
+        importlib.reload(show.main)
+        import config.main
+        importlib.reload(config.main)
+        from .mock_tables import dbconnector
+        from .mock_tables import mock_multi_asic
+        importlib.reload(mock_multi_asic)
+        dbconnector.load_namespace_config()
+
+    def test_config_suppress_fib_pending_all_asics(self):
+        runner = CliRunner()
+        db = Db()
+        cfgdb0 = db.cfgdb_clients['asic0']
+        cfgdb1 = db.cfgdb_clients['asic1']
+
+        # Test config = disable and db check for all asics (asic0 and asic1)
+        result = runner.invoke(config.config.commands['suppress-fib-pending'], ['disabled'], obj=db)
+        print(result.output)
+        assert result.exit_code == 0
+        assert cfgdb0.get_entry('DEVICE_METADATA', 'localhost')['suppress-fib-pending'] == 'disabled'
+        assert cfgdb1.get_entry('DEVICE_METADATA', 'localhost')['suppress-fib-pending'] == 'disabled'
+
+        # Show disable for all asics
+        result = runner.invoke(show.cli.commands['suppress-fib-pending'], obj=db)
+        assert result.exit_code == 0
+        assert result.output == 'asic0: Disabled\nasic1: Disabled\n'
+
+        # Test config = enable and db check for all asics (asic0 and asic1)
+        result = runner.invoke(config.config.commands['suppress-fib-pending'], ['enabled'], obj=db)
+        print(result.output)
+        assert result.exit_code == 0
+        assert cfgdb0.get_entry('DEVICE_METADATA', 'localhost')['suppress-fib-pending'] == 'enabled'
+        assert cfgdb1.get_entry('DEVICE_METADATA', 'localhost')['suppress-fib-pending'] == 'enabled'
+
+        # Show enable for all asics
+        result = runner.invoke(show.cli.commands['suppress-fib-pending'], obj=db)
+        assert result.exit_code == 0
+        assert result.output == 'asic0: Enabled\nasic1: Enabled\n'
+
+    @classmethod
+    def teardown_class(cls):
+        print("TEARDOWN")
+        os.environ["UTILITIES_UNIT_TESTING"] = "0"
+        os.environ["UTILITIES_UNIT_TESTING_TOPOLOGY"] = ""
+        from .mock_tables import dbconnector
+        from .mock_tables import mock_single_asic
+        importlib.reload(mock_single_asic)
+        dbconnector.load_namespace_config()