Skip to content

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Aug 20, 2025

Description

We were also installing chai in both @vitest/expect and vitest. This duplicated the amount of work Node.js needs to do. Removing chai from vitest (but keeping it in expect) removes ~10ms at startup for every test file.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 1e2b6ce
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68ac458d695d8b0008a10472
😎 Deploy Preview https://deploy-preview-8461--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

"devDependencies": {
"@vitest/runner": "workspace:*",
"rollup-plugin-copy": "^3.5.0"
"chai": "catalog:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest ^5 and 6 versions should be good now, no need for bundling.

const startTime = performance.now();

await import("chai");
// "chai": "5.2.1" > 4.39 ms
// "chai": "5.3.1" > 13.52 ms
// "chai": "5.3.2" > 2.92 ms
// "chai": "6.0.0" > 2.87 ms

console.log(`${(performance.now() - startTime).toFixed(2)} ms`);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Let's keep chai in dependencies.

@sheremet-va sheremet-va changed the title perf: bundle chai and loupe, remove chai as a direct dependency perf: remove chai as a direct dependency, keep it in @vitest/expect Aug 25, 2025
@sheremet-va sheremet-va merged commit cc98c61 into vitest-dev:main Aug 25, 2025
18 of 24 checks passed
@sheremet-va sheremet-va deleted the perf/bundle-chai branch August 25, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants