Skip to content

fix(workspace): forward inspect related cli options #7373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix(workspace): forward inspect related cli options #7373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc4c02e
fix(workspace): forward `inspect` related cli options
AriPerkkio Jan 28, 2025
59b6b26
test(browser): `--inspect-brk` with workspaces
AriPerkkio Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/vitest/src/node/workspace/resolveWorkspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ export async function resolveWorkspace(
'bail',
'isolate',
'printConsoleTrace',
'inspect',
'inspectBrk',
'fileParallelism',
Comment on lines +47 to +49
Copy link
Member Author

@AriPerkkio AriPerkkio Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably pass --browser too, as this kind of situation is kind of weird:

image

Copy link
Member Author

@AriPerkkio AriPerkkio Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well it's not actually as simple as adding browser in the CLI overrides. The resolveConfig is overwriting browser.enabled.

] as const

const cliOverrides = overridesOptions.reduce((acc, name) => {
Expand Down Expand Up @@ -73,7 +76,7 @@ export async function resolveWorkspace(
projectPromises.push(concurrent(() => initializeProject(
index,
vitest,
{ ...options, root, configFile },
{ ...options, root, configFile, test: { ...options.test, ...cliOverrides } },
)))
})

Expand Down
1 change: 1 addition & 0 deletions test/browser/fixtures/inspect/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export default defineConfig({
test: {
watch: false,
browser: {
enabled: true,
provider: "playwright",
name: "chromium",
headless: true,
Expand Down
22 changes: 22 additions & 0 deletions test/browser/fixtures/inspect/vitest.config.with-workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
server: { port: 5199 },
test: {
watch: false,

workspace: [
{
test: {
name: "Browser in workspace",
browser: {
provider: "playwright",
enabled: true,
headless: true,
instances: [{ browser: "chromium" }]
},
},
},
],
},
});
18 changes: 9 additions & 9 deletions test/browser/specs/inspect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ type Message = Partial<InspectorNotification<any>>
const IS_PLAYWRIGHT = process.env.PROVIDER === 'playwright'
const REMOTE_DEBUG_URL = '127.0.0.1:9123'

test.runIf(IS_PLAYWRIGHT || !process.env.CI)('--inspect-brk stops at test file', async () => {
const { vitest, waitForClose } = await runVitestCli(
'--root',
'fixtures/inspect',
'--browser',
'--no-file-parallelism',
'--inspect-brk',
REMOTE_DEBUG_URL,
)
test.runIf(IS_PLAYWRIGHT || !process.env.CI).each(['', 'with workspace'])('--inspect-brk stops at test file %s', async (isWorkspace) => {
const options = ['--root', 'fixtures/inspect', '--no-file-parallelism', '--inspect-brk', REMOTE_DEBUG_URL]

if (isWorkspace) {
options.push('--config')
options.push('vitest.config.with-workspace.ts')
}

const { vitest, waitForClose } = await runVitestCli(...options)

await vitest.waitForStdout(`Debugger listening on ws://${REMOTE_DEBUG_URL}`)

Expand Down