Skip to content

Conversation

@userquin
Copy link
Member

@userquin userquin commented Jan 14, 2025

Description

Running test:ci script on Windows (using Command Prompt or Power Shell) getting the following errors (check screenshots errors below):

  • test/config/test/exec-args.test.ts: running vmThreads the args using \\ in the path
  • test/dts-fixture: the test script running the build command => rm -rf dist && tsc -p tsconfig.json
  • test/cli/test/git-changed.test.ts: I have still no idea why it is failing (maybe ESLint Service in my WebStorm IDE, now it is working)
  • test/snapshots: the test script running the build command => "test:generate": "rm -rf ./test-update && cp -r ./test/fixtures/test-update ./test-update"
test/config/test/exec-args.test.ts error

This screenshot writting arguments to the console test/config/fixtures/exec-args-fixtures/vmThreads.test.ts
imagen

The error:
imagen

test/dts-fixture error

imagen

test/cli/test/git-changed.test.ts errors

First error:
imagen

Second Error:
imagen

test/snapshots error

imagen

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@userquin userquin marked this pull request as ready for review January 14, 2025 20:09
@userquin userquin requested a review from hi-ogawa January 14, 2025 20:20
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought pnpm's shell-emulator=true covers rm -rf and such, but apparently it doesn't magically handle unknown command 😓 Thanks for the fix!

@hi-ogawa hi-ogawa merged commit d4ea0b5 into main Jan 14, 2025
13 checks passed
@hi-ogawa hi-ogawa deleted the userquin/chore-fix-test-ci-error-on-windows branch January 14, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants