-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(browser): Improve unique CSS selector generation #6243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheremet-va
merged 2 commits into
vitest-dev:main
from
zacharyvoase:fix-unique-css-selectors
Jul 30, 2024
Merged
fix(browser): Improve unique CSS selector generation #6243
sheremet-va
merged 2 commits into
vitest-dev:main
from
zacharyvoase:fix-unique-css-selectors
Jul 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Here's the error before the fix is applied: |
3c666be to
572d5a5
Compare
Contributor
Author
|
I'm not sure what happened to the macos-14 webkit test, it looks like it may have been a timeout? |
sheremet-va
approved these changes
Jul 30, 2024
Member
|
Thank you! The test on Windows is flaky, ignore it for now |
Member
|
Note: in the future we will be using Playwright locators directly: #6084 |
This was referenced Aug 28, 2024
This was referenced Sep 10, 2024
This was referenced Sep 18, 2024
This was referenced Oct 10, 2024
1 task
This was referenced Feb 4, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6211
Description
Currently the User Interactivity API, which is required to interact with any elements via the browser, generates a unique CSS selector based on the element requested. However, there are two main cases where this fails:
:; andI've added a test here that fails with the current code, and passes with the changes.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.