fix(pool): auto-adjust minWorkers when only maxWorkers specified (#8110)

Author: AriPerkkio

packages/vitest/src/node/pools/forks.ts

@@ -79,7 +79,7 @@ export function createForksPool(
   const maxThreads
     = poolOptions.maxForks ?? vitest.config.maxWorkers ?? threadsCount
   const minThreads
-    = poolOptions.minForks ?? vitest.config.minWorkers ?? threadsCount
+    = poolOptions.minForks ?? vitest.config.minWorkers ?? Math.min(threadsCount, maxThreads)
 
   const worker = resolve(vitest.distPath, 'workers/forks.js')
 

packages/vitest/src/node/pools/threads.ts

@@ -57,7 +57,7 @@ export function createThreadsPool(
   const maxThreads
     = poolOptions.maxThreads ?? vitest.config.maxWorkers ?? threadsCount
   const minThreads
-    = poolOptions.minThreads ?? vitest.config.minWorkers ?? threadsCount
+    = poolOptions.minThreads ?? vitest.config.minWorkers ?? Math.min(threadsCount, maxThreads)
 
   const worker = resolve(vitest.distPath, 'workers/threads.js')
 

packages/vitest/src/node/pools/vmForks.ts

@@ -85,7 +85,7 @@ export function createVmForksPool(
   const maxThreads
     = poolOptions.maxForks ?? vitest.config.maxWorkers ?? threadsCount
   const minThreads
-    = poolOptions.maxForks ?? vitest.config.minWorkers ?? threadsCount
+    = poolOptions.maxForks ?? vitest.config.minWorkers ?? Math.min(threadsCount, maxThreads)
 
   const worker = resolve(vitest.distPath, 'workers/vmForks.js')
 

packages/vitest/src/node/pools/vmThreads.ts

@@ -60,7 +60,7 @@ export function createVmThreadsPool(
   const maxThreads
     = poolOptions.maxThreads ?? vitest.config.maxWorkers ?? threadsCount
   const minThreads
-    = poolOptions.minThreads ?? vitest.config.minWorkers ?? threadsCount
+    = poolOptions.minThreads ?? vitest.config.minWorkers ?? Math.min(threadsCount, maxThreads)
 
   const worker = resolve(vitest.distPath, 'workers/vmThreads.js')
 

test/config/test/failures.test.ts

@@ -1,8 +1,8 @@
 import type { UserConfig as ViteUserConfig } from 'vite'
 import type { UserConfig } from 'vitest/node'
 import type { VitestRunnerCLIOptions } from '../../test-utils'
+import { cpus } from 'node:os'
 import { normalize, resolve } from 'pathe'
-
 import { beforeEach, expect, test } from 'vitest'
 import { version } from 'vitest/package.json'
 import * as testUtils from '../../test-utils'
@@ -12,7 +12,7 @@ const names = ['edge', 'chromium', 'webkit', 'chrome', 'firefox', 'safari'] as c
 const browsers = providers.map(provider => names.map(name => ({ name, provider }))).flat()
 
 function runVitest(config: NonNullable<UserConfig> & { shard?: any }, viteOverrides: ViteUserConfig = {}, runnerOptions?: VitestRunnerCLIOptions) {
-  return testUtils.runVitest({ root: './fixtures/test', ...config }, [], undefined, viteOverrides, runnerOptions)
+  return testUtils.runVitest({ root: './fixtures/test', include: ['example.test.ts'], ...config }, [], undefined, viteOverrides, runnerOptions)
 }
 
 function runVitestCli(...cliArgs: string[]) {
@@ -553,3 +553,23 @@ test('non existing project name array will throw', async () => {
   const { stderr } = await runVitest({ project: ['non-existing-project', 'also-non-existing'] })
   expect(stderr).toMatch('No projects matched the filter "non-existing-project", "also-non-existing".')
 })
+
+test('minWorkers must be smaller than maxWorkers', async () => {
+  const { stderr } = await runVitest({ minWorkers: 2, maxWorkers: 1 })
+
+  expect(stderr).toMatch('RangeError: options.minThreads and options.maxThreads must not conflict')
+})
+
+test('minWorkers higher than maxWorkers does not crash', async ({ skip }) => {
+  skip(cpus().length < 2, 'Test requires +2 CPUs')
+
+  const { stdout, stderr } = await runVitest({
+    maxWorkers: 1,
+
+    // Overrides defaults of "runVitest" of "test-utils"
+    minWorkers: undefined,
+  })
+
+  expect(stdout).toMatch('✓ example.test.ts > it works')
+  expect(stderr).toBe('')
+})