fix(coverage): istanbul provider to not use Vite preserved query params

AriPerkkio · AriPerkkio · commit 0a5079c91f48 · 2025-05-08T13:39:29.000+03:00
diff --git a/packages/coverage-istanbul/src/provider.ts b/packages/coverage-istanbul/src/provider.ts
@@ -61,7 +61,7 @@ export class IstanbulCoverageProvider extends BaseCoverageProvider<ResolvedCover
   }
 
   onFileTransform(sourceCode: string, id: string, pluginCtx: any): { code: string; map: any } | undefined {
-    if (!this.testExclude.shouldInstrument(id)) {
+    if (!this.testExclude.shouldInstrument(removeQueryParameters(id))) {
       return
     }
 
@@ -199,7 +199,7 @@ export class IstanbulCoverageProvider extends BaseCoverageProvider<ResolvedCover
       }
 
       // Make sure file is not served from cache so that instrumenter loads up requested file coverage
-      await transform(`${filename}?v=${cacheKey}`)
+      await transform(`${filename}?cache=${cacheKey}`)
       const lastCoverage = this.instrumenter.lastFileCoverage()
       coverageMap.addFileCoverage(lastCoverage)
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ export class IstanbulCoverageProvider extends BaseCoverageProvider<ResolvedCover`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`onFileTransform(sourceCode: string, id: string, pluginCtx: any): { code: string; map: any } \| undefined {`
`64`		`- if (!this.testExclude.shouldInstrument(id)) {`
	`64`	`+ if (!this.testExclude.shouldInstrument(removeQueryParameters(id))) {`
`65`	`65`	`return`
`66`	`66`	`}`
`67`	`67`
`@@ -199,7 +199,7 @@ export class IstanbulCoverageProvider extends BaseCoverageProvider<ResolvedCover`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`// Make sure file is not served from cache so that instrumenter loads up requested file coverage`
`202`		- await transform(`${filename}?v=${cacheKey}`)
	`202`	+ await transform(`${filename}?cache=${cacheKey}`)
`203`	`203`	`const lastCoverage = this.instrumenter.lastFileCoverage()`
`204`	`204`	`coverageMap.addFileCoverage(lastCoverage)`
`205`	`205`