chore(prefer-called-exactly-once-with): clarify message (#792)

* chore: clarify prefer-called-exactly-once-with rule message

* test: update test

* Update src/rules/prefer-called-exactly-once-with.ts

* Update src/rules/prefer-called-exactly-once-with.ts

* update lines

---------

Co-authored-by: Verité Mugabo <[email protected]>

Author: y-hsgw

src/rules/prefer-called-exactly-once-with.ts

@@ -145,7 +145,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     },
     messages: {
       preferCalledExactlyOnceWith:
-        'Prefer {{matcherName}} (/* expected args */)',
+        'Using `toHaveBeenCalledOnce` and `toHaveBeenCalledWith` on the same target; prefer `toHaveBeenCalledExactlyOnceWith` instead.',
     },
     type: 'suggestion',
     fixable: 'code',
@@ -217,8 +217,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         if (!targetNode) continue
 
         const { callExpression: firstCallExpression } = firstMatcherReference
-        const { callExpression: secondCallExpression, matcherName } =
-          secondMatcherReference
+        const { callExpression: secondCallExpression } = secondMatcherReference
 
         if (
           hasMockResetBetween(body, firstCallExpression, secondCallExpression)
@@ -228,7 +227,6 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         context.report({
           messageId: 'preferCalledExactlyOnceWith',
           node: targetNode,
-          data: { matcherName },
           fix(fixer) {
             const indentation = sourceCode.text.slice(
               firstCallExpression.parent.range[0],

tests/prefer-called-exactly-once-with.test.ts

@@ -57,7 +57,6 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'preferCalledExactlyOnceWith',
-          data: { matcherName: 'toHaveBeenCalledWith' },
           column: 17,
           line: 3,
         },
@@ -74,7 +73,6 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'preferCalledExactlyOnceWith',
-          data: { matcherName: 'toHaveBeenCalledOnce' },
           column: 17,
           line: 3,
         },
@@ -91,7 +89,6 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'preferCalledExactlyOnceWith',
-          data: { matcherName: 'toHaveBeenCalledOnce' },
           column: 17,
           line: 3,
         },
@@ -110,7 +107,6 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'preferCalledExactlyOnceWith',
-          data: { matcherName: 'toHaveBeenCalledOnce' },
           column: 19,
           line: 4,
         },
@@ -131,13 +127,11 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'preferCalledExactlyOnceWith',
-          data: { matcherName: 'toHaveBeenCalledOnce' },
           column: 17,
           line: 3,
         },
         {
           messageId: 'preferCalledExactlyOnceWith',
-          data: { matcherName: 'toHaveBeenCalledOnce' },
           column: 17,
           line: 5,
         },
@@ -156,7 +150,6 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'preferCalledExactlyOnceWith',
-          data: { matcherName: 'toHaveBeenCalledOnce' },
           column: 17,
           line: 4,
         },
@@ -175,7 +168,6 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'preferCalledExactlyOnceWith',
-          data: { matcherName: 'toHaveBeenCalledWith' },
           column: 17,
           line: 4,
         },