Skip to content

Conversation

@sapphi-red
Copy link
Member

Description

backend-intergration build test was failing on my machine.

refs #17886

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Aug 21, 2024
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

origin: 'http://localhost:5009',
},
preview: {
port: 5009,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server.strictPort is inherited to preview.strictPort and therefore the playground tried to listen to port 4173 even if one of the other playground is listening to it.
Specified the port number to avoid conflict.

@sapphi-red sapphi-red enabled auto-merge (squash) August 21, 2024 11:49
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same while merging main in the v6 PR. I thought it was something that was only exposed there. I added strictPort that I thought was needed though. It feels a bit weird that we inherit this from the server config. Maybe one day we could do a breaking change and made this two independent.

@sapphi-red sapphi-red merged commit dbd6214 into vitejs:main Aug 21, 2024
@sapphi-red sapphi-red deleted the test/fix-backend-intergration-build-test-flaky-fail branch August 21, 2024 14:41
@sapphi-red
Copy link
Member Author

It feels a bit weird that we inherit this from the server config. Maybe one day we could do a breaking change and made this two independent.

Yeah, I agree this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority) test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants