Skip to content

fix(sourcemap): improve sourcemap compatibility for vue2 #16594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2024
Merged

fix(sourcemap): improve sourcemap compatibility for vue2 #16594

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17149f4
feat: Improve sourcemap compatibility for vue2
amweiss May 4, 2024
0832904
Use cleanUrl
amweiss May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vite/src/node/server/sourcemap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import fsp from 'node:fs/promises'
import convertSourceMap from 'convert-source-map'
import type { ExistingRawSourceMap, SourceMap } from 'rollup'
import type { Logger } from '../logger'
import { blankReplacer, createDebugger } from '../utils'
import { blankReplacer, createDebugger, fsPathFromUrl } from '../utils'

const debug = createDebugger('vite:sourcemap', {
onlyWhenFocused: true,
Expand Down Expand Up @@ -53,7 +53,7 @@ export async function injectSourcesContent(
// inject content from source file when sourcesContent is null
sourceRootPromise ??= computeSourceRoute(map, file)
const sourceRoot = await sourceRootPromise
let resolvedSourcePath = decodeURI(sourcePath)
let resolvedSourcePath = fsPathFromUrl(decodeURI(sourcePath))
if (sourceRoot) {
resolvedSourcePath = path.resolve(sourceRoot, resolvedSourcePath)
}
Expand Down