feat(build): add copyPublicDir option #10550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
build.copyPublicDir: booleanoption to control whether to copy thepublicDirtooutDir. Defaulttrue.Additional context
Case
Vite default build copies files in
publicDirtooutDir. In common cases, this isn't useful for SSR builds as the client build already contains thepublicDirfiles. To avoid unnecessary files, SvelteKit and Astro setspublicDir: falseto turn it off.Problem
However, turning it off disallows
import img from '/favicon.png', which is possible withplugin-vue's asset transform:Which would error on SSR build as Vite can resolve
/...imports from thepublicDir. (withastro/astro#5063) (Extrabase/publicDirdiscussion: #9276)Solution
publicDirin SSR builds by default (could be breaking)publicDiras documented (Though the discussion above say otherwise Allow importing public files for base support #9276)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).