fix(legacy): skip esbuild transform for systemjs#9635
Conversation
|
#8660 is causing this issue. #8660 set |
patak-cat
left a comment
There was a problem hiding this comment.
This looks good to me as a hot patch, we can later review doing it in other cases too. Merging and running vite-ecosystem-ci, let's release vite and plugin-legacy
|
@sapphi-red saw your message after writing mine, we can do another release later with a better method if you want to do that PR. |
|
The difficult point is, when bundling a code with esbuild:
Most code won't have any problem with transpiling es5 --(esbuild)--> es2015 --(babel)--> es5. |
I'm not sure about this. To be safe, maybe we should use terser with these options? |
Description
fix #9618
The gist of the issue is that the esbuild plugin is used to built the polyfill chunk which includes the systemjs code. This PR skips esbuild for it.
Additional context
I think there are many ways to tackle this, so happy to discuss the best option here. e.g. should we always avoid esbuild for polyfill chunks?
I think this may invalidate #9453 too.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).