chore: use tsx directly instead of indirect esno#8773
Merged
patak-cat merged 6 commits intovitejs:mainfrom Jun 25, 2022
JounQin:chore/tsx_esno
Merged
chore: use tsx directly instead of indirect esno#8773patak-cat merged 6 commits intovitejs:mainfrom JounQin:chore/tsx_esno
tsx directly instead of indirect esno#8773patak-cat merged 6 commits intovitejs:mainfrom
JounQin:chore/tsx_esno
Conversation
✅ Deploy Preview for vite-docs-main canceled.
|
Contributor
Author
|
|
Contributor
Author
bluwy
reviewed
Jun 25, 2022
Shinigami92
reviewed
Jun 25, 2022
Member
Shinigami92
left a comment
Shinigami92
left a comment
There was a problem hiding this comment.
I would approve it, but cannot, because there are 3 lines not related to this PR directly 🤔
So other maintainers should decide if they are okay with these lines
bluwy
changed the title
tsx directly instead of indirect esnotsx directly instead of indirect esno
JounQin
commented
Jun 25, 2022
sapphi-red
reviewed
Jun 25, 2022
| ], | ||
| "scripts": { | ||
| "preinstall": "npx only-allow pnpm", | ||
| "postinstall": "simple-git-hooks", |
Member
There was a problem hiding this comment.
This will make simple-git-hooks run every time pnpm i is called. But I think it is good to have this for new contributors.
Ideally it is better to turn off side-effects-cache only for simple-git-hooks. I'm not sure if we can do this.
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Perhaps we can include it for now until an issue arise, otherwise we can point users to run it manually in the contributing guide.
bluwy
approved these changes
Jun 25, 2022
Shinigami92
approved these changes
Jun 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
related #8771
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).