Skip to content

fix(plugin-legacy): prevent failed to load module#8285

Merged
patak-cat merged 2 commits intovitejs:mainfrom
sapphi-red:fix/legacy-import-html-error
May 23, 2022
Merged

fix(plugin-legacy): prevent failed to load module#8285
patak-cat merged 2 commits intovitejs:mainfrom
sapphi-red:fix/legacy-import-html-error

Conversation

@sapphi-red
Copy link
Member

Description

#7644 changed legacy detection code to try{import(new URL(import.meta.url).href).catch(()=>1);}catch(e){}window.${detectModernBrowserVarName}=true;.
When import.meta and dynamic import is supported, a fetch to current location which normally returns html will be executed.
That fetch occurs Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/html". Strict MIME type checking is enforced for module scripts per HTML spec. error.

Note that import('_') does not show any error. I'm not sure but maybe because _ is not a valid url.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: legacy p2-nice-to-have Not breaking anything but nice to have (priority) labels May 23, 2022
Copy link
Member

@patak-cat patak-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good one!

@patak-cat patak-cat enabled auto-merge (squash) May 23, 2022 06:36
@patak-cat patak-cat merged commit d671811 into vitejs:main May 23, 2022
@sapphi-red sapphi-red deleted the fix/legacy-import-html-error branch May 23, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants