fix(plugin-legacy): prevent failed to load module#8285
Merged
patak-cat merged 2 commits intovitejs:mainfrom May 23, 2022
Merged
fix(plugin-legacy): prevent failed to load module#8285patak-cat merged 2 commits intovitejs:mainfrom
patak-cat merged 2 commits intovitejs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#7644 changed legacy detection code to
try{import(new URL(import.meta.url).href).catch(()=>1);}catch(e){}window.${detectModernBrowserVarName}=true;.When
import.metaand dynamic import is supported, a fetch to current location which normally returns html will be executed.That fetch occurs
Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/html". Strict MIME type checking is enforced for module scripts per HTML spec.error.Note that
import('_')does not show any error. I'm not sure but maybe because_is not a valid url.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).