Skip to content

fix(plugin-legacy): bake-in Promise polyfill, fix #4414#4440

Merged
patak-cat merged 1 commit intovitejs:mainfrom
AlexandreBonaventure:ie-promise-polyfill
Jul 29, 2021
Merged

fix(plugin-legacy): bake-in Promise polyfill, fix #4414#4440
patak-cat merged 1 commit intovitejs:mainfrom
AlexandreBonaventure:ie-promise-polyfill

Conversation

@AlexandreBonaventure
Copy link
Contributor

Description

This fixes support for ie11 with legacy plugin.
see #4414 for the reasoning
This adds 2 polyfills per default, which can maybe improved by only injecting them when required (ie: only for ie11 and below) and not add to the bundle size for those that supports Promise

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added p3-minor-bug An edge case that only affects very specific usage (priority) plugin: legacy labels Jul 29, 2021
@patak-cat patak-cat changed the title fix(legacy): bake-in Promise polyfill (fixes #4414) fix(plugin-legacy): bake-in Promise polyfill, fix #4414 Jul 29, 2021
@patak-cat patak-cat merged commit 024a2de into vitejs:main Jul 29, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority) plugin: legacy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants