fix(plugin-legacy): replace esbuild-plugin-browserslist with browserslist-to-esbuild#15988
Merged
patak-cat merged 2 commits intovitejs:mainfrom Feb 21, 2024
Merged
fix(plugin-legacy): replace esbuild-plugin-browserslist with browserslist-to-esbuild#15988patak-cat merged 2 commits intovitejs:mainfrom
esbuild-plugin-browserslist with browserslist-to-esbuild#15988patak-cat merged 2 commits intovitejs:mainfrom
Conversation
|
|
Member
|
Maybe we should switch to https://www.npmjs.com/package/browserslist-to-esbuild instead to avoid that peer dep. The API we're using shouldn't need to use esbuild, so I think we should avoid depending on |
esbuild-plugin-browserslist with browserslist-to-esbuild
esbuild-plugin-browserslist with browserslist-to-esbuildesbuild-plugin-browserslist with browserslist-to-esbuild
Member
|
It seems this PR broke several downstream CIs: Example: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/8005338357/job/21864542117 @btea let us know if you have an idea to fix this, if not I think we should revert it for now. |
Member
|
It looks like |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I execute
pnpm ithe following warning message appears.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).