fix(legacy): import @babel/preset-env#12961
Merged
sapphi-red merged 2 commits intovitejs:mainfrom May 2, 2023
Merged
Conversation
|
|
bluwy
approved these changes
Apr 24, 2023
|
Release a new version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@vitejs/plugin-legacyspecifies that Babel should use@babel/preset-envbut doesn't specify where it should resolve it from so Babel defaults toprocess.cwd(), usually the current project, making it rely on hoisting.This PR fixes that by dynamically importing
@babel/preset-envand passing the result to Babel.Alternatively one could use the Babel option
cwdto make it resolve relative to@vitejs/plugin-legacyor userequire.resolveto give Babel an absolute path to the preset.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).