Skip to content

fix(plugin-legacy): legacy sourcemap not generate (fix #11693)#11841

Merged
patak-cat merged 2 commits intovitejs:mainfrom
sun0day:fix/pluginLegacySourcemap
Jan 31, 2023
Merged

fix(plugin-legacy): legacy sourcemap not generate (fix #11693)#11841
patak-cat merged 2 commits intovitejs:mainfrom
sun0day:fix/pluginLegacySourcemap

Conversation

@sun0day
Copy link
Member

@sun0day sun0day commented Jan 29, 2023

Description

fix #11693

Additional context

plugin-legacy should compatible with rollup3.x: don't delete sourcemap in bundle

See rollup3.x break changes

When using the API and sourcemaps, sourcemap comments are contained in the emitted files and sourcemaps are emitted as regular assets (#4605)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: legacy p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release labels Jan 29, 2023
@sapphi-red
Copy link
Member

Thank you for the PR!
Would you add a test for this?

@sun0day
Copy link
Member Author

sun0day commented Jan 29, 2023

Thank you for the PR! Would you add a test for this?

Done

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-cat patak-cat merged commit 2ff5930 into vitejs:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p4-important Violate documented behavior or significantly improves performance (priority) plugin: legacy regression The issue only appears after a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The [name]-legacy-[hash].js file generated by vite@4.x and @vitejs/plugin-legacy does not have a sourcemap

3 participants