fix(resolve): warn if node-like builtin was imported when resolve.builtin is empty (#19312)

Author: sapphi-red

packages/vite/src/node/__tests__/resolve.spec.ts

@@ -1,5 +1,5 @@
 import { join } from 'node:path'
-import { describe, expect, onTestFinished, test } from 'vitest'
+import { describe, expect, onTestFinished, test, vi } from 'vitest'
 import { createServer } from '../server'
 import { createServerModuleRunner } from '../ssr/runtime/serverModuleRunner'
 import type { EnvironmentOptions, InlineConfig } from '../config'
@@ -176,6 +176,11 @@ describe('file url', () => {
       idToResolve: string
     }) {
       const server = await createServer(getConfig(targetEnv, builtins))
+      vi.spyOn(server.config.logger, 'warn').mockImplementationOnce(
+        (message) => {
+          throw new Error(message)
+        },
+      )
       onTestFinished(() => server.close())
 
       return server.environments[testEnv]?.pluginContainer.resolveId(
@@ -218,7 +223,7 @@ describe('file url', () => {
           idToResolve: 'node:fs',
         }),
       ).rejects.toThrowError(
-        /Automatically externalized node built-in module "node:fs"/,
+        /warning: Automatically externalized node built-in module "node:fs"/,
       )
     })
 

packages/vite/src/node/plugins/resolve.ts

@@ -427,7 +427,7 @@ export function resolvePlugin(
               )}"`
             }
             message += `. Consider adding it to environments.${this.environment.name}.external if it is intended.`
-            this.error(message)
+            this.warn(message)
           }
 
           return options.idOnly