Skip to content

chore(rsc): use websocket for browser module runner transport#946

Merged
hi-ogawa merged 4 commits into
mainfrom
10-23-chore_rsc_use_websocket_for_browser_module_runner_transport
Oct 23, 2025
Merged

chore(rsc): use websocket for browser module runner transport#946
hi-ogawa merged 4 commits into
mainfrom
10-23-chore_rsc_use_websocket_for_browser_module_runner_transport

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Description

Or isn't it possible to reuse import.meta.hot of the actual client environment?

Indeed, we can just proxy invoke through vite-dep-rpc https://github.com/antfu/vite-dev-rpc/

@hi-ogawa hi-ogawa marked this pull request as ready for review October 23, 2025 07:33
@hi-ogawa

Copy link
Copy Markdown
Contributor Author

@kasperpeulen Hi! Just wanted to let you know about this change here. We've talked about each fetch of invoke call being slow. This PR changed it to use websocket for transport. I'm not sure if this actually improves performance, but at least, the network log won't get flooded.

@hi-ogawa hi-ogawa merged commit 165b5d5 into main Oct 23, 2025
20 checks passed
@hi-ogawa hi-ogawa deleted the 10-23-chore_rsc_use_websocket_for_browser_module_runner_transport branch October 23, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant