Skip to content

feat(splash): add support for new iphone models#67

Open
wiyco wants to merge 1 commit into
vite-pwa:mainfrom
wiyco:feat/splash/new-apple-devices
Open

feat(splash): add support for new iphone models#67
wiyco wants to merge 1 commit into
vite-pwa:mainfrom
wiyco:feat/splash/new-apple-devices

Conversation

@wiyco

@wiyco wiyco commented Dec 19, 2025

Copy link
Copy Markdown

Description

This PR adds splash screen definitions for the new iPhone models to src/splash.ts.

Added Devices:

  • iPhone 17 Pro Max
  • iPhone 17 Pro
  • iPhone Air (new resolution)
  • iPhone 17

The resolutions and scale factors are based on the Apple Developer Documentation.
https://developer.apple.com/design/human-interface-guidelines/layout#iOS-iPadOS-device-screen-dimensions

Linked Issues

None.

Additional Context

Validated with nr lint and nr test.

@userquin

Copy link
Copy Markdown
Member

We need to change apple device name type to allow adding new models without having them released here.

@wiyco

wiyco commented Dec 20, 2025

Copy link
Copy Markdown
Author

That makes sense. 👍

My understanding is that relaxing the AppleDeviceName type allows users to manually extend appleSplashScreenSizes with their own definitions, avoiding the issue where a custom name would otherwise resolve to undefined sizes.

I will update the type to allow arbitrary strings while preserving autocomplete.

export type KnownAppleDeviceName
  = | 'iPad Pro 12.9"'
    // existing devices
      
export type AppleDeviceName = KnownAppleDeviceName | (string & {})

export interface AppleSplashScreen extends Record<AppleDeviceName, AppleDeviceSize> {}

@userquin

Copy link
Copy Markdown
Member

Yeah, that's the idea, send a new pr 🙏 .

I won't be back from vacation until mid-January, please be patient. I will review the pr and maybe Anthony can do the release.

@marijoo

marijoo commented Jun 9, 2026

Copy link
Copy Markdown

Will this be merged sometime? Thanks for the plugin! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants