feat(splash): add support for new iphone models#67
Open
wiyco wants to merge 1 commit into
Open
Conversation
Member
|
We need to change apple device name type to allow adding new models without having them released here. |
Author
|
That makes sense. 👍 My understanding is that relaxing the I will update the type to allow arbitrary strings while preserving autocomplete. export type KnownAppleDeviceName
= | 'iPad Pro 12.9"'
// existing devices
export type AppleDeviceName = KnownAppleDeviceName | (string & {})
export interface AppleSplashScreen extends Record<AppleDeviceName, AppleDeviceSize> {} |
Member
|
Yeah, that's the idea, send a new pr 🙏 . I won't be back from vacation until mid-January, please be patient. I will review the pr and maybe Anthony can do the release. |
|
Will this be merged sometime? Thanks for the plugin! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds splash screen definitions for the new iPhone models to
src/splash.ts.Added Devices:
The resolutions and scale factors are based on the Apple Developer Documentation.
https://developer.apple.com/design/human-interface-guidelines/layout#iOS-iPadOS-device-screen-dimensions
Linked Issues
None.
Additional Context
Validated with
nr lintandnr test.