Skip to content

feat: add new Apple devices#64

Merged
userquin merged 2 commits into
vite-pwa:mainfrom
felixicaza:feat/devices
Sep 7, 2025
Merged

feat: add new Apple devices#64
userquin merged 2 commits into
vite-pwa:mainfrom
felixicaza:feat/devices

Conversation

@felixicaza

Copy link
Copy Markdown
Contributor

Description

This pull request updates the src/splash.ts file to add new Apple devices and their corresponding screen sizes, ensuring compatibility with the latest devices and update order entries. Based on iOS, iPadOS device screen dimensions.

Updates to Apple device names:

  • Added new iPad models: iPad Air 13", iPad Air 11", iPad Air 10.9", and iPad 11".
  • Added new iPhone models: iPhone 16 Pro Max, iPhone 16 Pro, iPhone 16 Plus, iPhone 16, iPhone 16e, iPhone 15 Pro Max, iPhone 15 Pro, iPhone 15 Plus, and iPhone 15.
  • Update order for iPad mini 7.9" and added iPad mini 8.3".

Linked Issues

None.

@Emiliano-Bucci

Copy link
Copy Markdown

Can this be merged?

Comment thread src/splash.ts
@pkg-pr-new

pkg-pr-new Bot commented Sep 4, 2025

Copy link
Copy Markdown
npm i https://pkg.pr.new/@vite-pwa/assets-generator@64

commit: 2e9cd81

@userquin

userquin commented Sep 4, 2025

Copy link
Copy Markdown
Member

@felixicaza can you add the Apple link to the AppleDeviceName const?

@felixicaza

Copy link
Copy Markdown
Contributor Author

@userquin Do you mean something like this?

/**
 * Apple device names and resolutions.
 * @see https://developer.apple.com/design/human-interface-guidelines/layout#iOS-iPadOS-device-screen-dimensions
 */
export const appleSplashScreenSizes: AppleSplashScreen = {
  'iPad Pro 12.9"': { width: 2048, height: 2732, scaleFactor: 2 },
  // ...
}

Sorry, I didn't quite understand.

@userquin

userquin commented Sep 5, 2025

Copy link
Copy Markdown
Member

Oh, it is there thx, will try to check the pr and release it maybe tmr.

@userquin userquin merged commit 53fb682 into vite-pwa:main Sep 7, 2025
2 checks passed
@felixicaza felixicaza deleted the feat/devices branch September 7, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants