feat: add new Apple devices#64
Merged
Merged
Conversation
|
Can this be merged? |
userquin
reviewed
Sep 4, 2025
commit: |
Member
|
@felixicaza can you add the Apple link to the |
Contributor
Author
|
@userquin Do you mean something like this? /**
* Apple device names and resolutions.
* @see https://developer.apple.com/design/human-interface-guidelines/layout#iOS-iPadOS-device-screen-dimensions
*/
export const appleSplashScreenSizes: AppleSplashScreen = {
'iPad Pro 12.9"': { width: 2048, height: 2732, scaleFactor: 2 },
// ...
}Sorry, I didn't quite understand. |
Member
|
Oh, it is there thx, will try to check the pr and release it maybe tmr. |
userquin
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
src/splash.tsfile to add new Apple devices and their corresponding screen sizes, ensuring compatibility with the latest devices and update order entries. Based on iOS, iPadOS device screen dimensions.Updates to Apple device names:
iPad Air 13",iPad Air 11",iPad Air 10.9", andiPad 11".iPhone 16 Pro Max,iPhone 16 Pro,iPhone 16 Plus,iPhone 16,iPhone 16e,iPhone 15 Pro Max,iPhone 15 Pro,iPhone 15 Plus, andiPhone 15.iPad mini 7.9"and addediPad mini 8.3".Linked Issues
None.