Merge pull request #96 from vimeo/pflag-remove-unnecessary

sergiosalvatore · web-flow · commit 5d23ad9fd89c · 2024-08-30T11:16:24.000-04:00
Remove Unnecessary Error from pflag
diff --git a/sources/pflag/pflag.go b/sources/pflag/pflag.go
@@ -445,8 +445,7 @@ func (s *Set) Value(_ context.Context, t *dials.Type) (reflect.Value, error) {
 			return reflect.Value{}, err
 		}
 	}
-	var setErr error
-	val := reflect.New(t.Type())
+
 	s.Flags.Visit(func(f *pflag.Flag) {
 		fieldName, ok := s.flagFieldName[f.Name]
 		if !ok {
@@ -492,9 +491,6 @@ func (s *Set) Value(_ context.Context, t *dials.Type) (reflect.Value, error) {
 			ffield.Set(cfval)
 		}
 	})
-	if setErr != nil {
-		return val.Elem(), setErr
-	}
 
 	return s.tfmr.ReverseTranslate(s.trnslVal)
 }

Original file line number	Diff line number	Diff line change
`@@ -445,8 +445,7 @@ func (s Set) Value(_ context.Context, t dials.Type) (reflect.Value, error) {`
`445`	`445`	`return reflect.Value{}, err`
`446`	`446`	`}`
`447`	`447`	`}`
`448`		`- var setErr error`
`449`		`- val := reflect.New(t.Type())`
	`448`	`+`
`450`	`449`	`s.Flags.Visit(func(f *pflag.Flag) {`
`451`	`450`	`fieldName, ok := s.flagFieldName[f.Name]`
`452`	`451`	`if !ok {`
`@@ -492,9 +491,6 @@ func (s Set) Value(_ context.Context, t dials.Type) (reflect.Value, error) {`
`492`	`491`	`ffield.Set(cfval)`
`493`	`492`	`}`
`494`	`493`	`})`
`495`		`- if setErr != nil {`
`496`		`- return val.Elem(), setErr`
`497`		`- }`
`498`	`494`
`499`	`495`	`return s.tfmr.ReverseTranslate(s.trnslVal)`
`500`	`496`	`}`