Remvoe some "TODO: SCTP" items

Author: ibc

worker/src/RTC/SCTP/association/Association.cpp

@@ -1,6 +1,5 @@
 #define MS_CLASS "RTC::SCTP::Association"
-// TODO: SCTP: COMMENT
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/association/Association.hpp"
 #include "Logger.hpp"
@@ -519,23 +518,23 @@ namespace RTC
 		{
 			MS_TRACE();
 
-			// TODO: SCTP: For testing purposes. Must be removed.
-			{
-				MS_DUMP("<<< received SCTP packet:");
+// For debugging purposes.
+#if MS_LOG_DEV_LEVEL == 3
+			MS_DUMP("<<< received SCTP packet:");
 
-				const auto* packet = RTC::SCTP::Packet::Parse(data, len);
+			const auto* packet = RTC::SCTP::Packet::Parse(data, len);
 
-				if (packet)
-				{
-					packet->Dump();
+			if (packet)
+			{
+				packet->Dump();
 
-					delete packet;
-				}
-				else
-				{
-					MS_ABORT("RTC::SCTP::Packet::Parse() failed to parse received SCTP data");
-				}
+				delete packet;
+			}
+			else
+			{
+				MS_ERROR("RTC::SCTP::Packet::Parse() failed to parse received SCTP data");
 			}
+#endif
 
 			this->privateMetrics.rxPacketsCount++;
 

worker/src/RTC/SCTP/association/HeartbeatHandler.cpp

@@ -1,6 +1,5 @@
 #define MS_CLASS "RTC::SCTP::HeartbeatHandler"
-// TODO: SCTP: COMMENT
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/association/HeartbeatHandler.hpp"
 #include "Logger.hpp"

worker/src/RTC/SCTP/association/PacketSender.cpp

@@ -33,12 +33,12 @@ namespace RTC
 				packet->WriteCRC32cChecksum();
 			}
 
-			// TODO: SCTP: For testing purposes. Must be removed.
-			{
-				MS_DUMP(">>> sending SCTP packet:");
+// For debugging purposes.
+#if MS_LOG_DEV_LEVEL == 3
+			MS_DUMP(">>> sending SCTP packet:");
 
-				packet->Dump();
-			}
+			packet->Dump();
+#endif
 
 			MS_ASSERT(!packet->NeedsConsolidation(), "cannot send a SCTP packet that needs consolidation");
 

worker/src/RTC/SCTP/association/StreamResetHandler.cpp

@@ -1,6 +1,5 @@
 #define MS_CLASS "RTC::SCTP::StreamResetHandler"
-// TODO: SCTP: COMMENT
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/association/StreamResetHandler.hpp"
 #include "Logger.hpp"
@@ -301,10 +300,6 @@ namespace RTC
 			// "In Progress" request. In all cases, re-evaluate the state.
 			this->lastProcessedReqSeqNbr = requestSn;
 
-			// TODO: SCTP: Remove (it's just to avoid "private field 'reassemblyQueue'
-			// is not used" wargning).
-			(void)this->reassemblyQueue;
-
 			if (
 			  this->dataTracker->IsLaterThanCumulativeAckedTsn(
 			    receivedOutgoingSsnResetRequestParameter->GetSenderLastAssignedTsn()))

worker/src/RTC/SCTP/association/TransmissionControlBlock.cpp

@@ -1,6 +1,5 @@
 #define MS_CLASS "RTC::SCTP::TransmissionControlBlock"
-// TODO: SCTP: COMMENT
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/association/TransmissionControlBlock.hpp"
 #include "Logger.hpp"

worker/src/RTC/SCTP/packet/chunks/ShutdownCompleteChunk.cpp

@@ -1,5 +1,5 @@
 #define MS_CLASS "RTC::SCTP::ShutdownCompleteChunk"
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/packet/chunks/ShutdownCompleteChunk.hpp"
 #include "Logger.hpp"

worker/src/RTC/SCTP/rx/DataTracker.cpp

@@ -1,6 +1,5 @@
 #define MS_CLASS "RTC::SCTP::DataTracker"
-// TODO: SCTP: COMMENT
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/rx/DataTracker.hpp"
 #include "Logger.hpp"
@@ -181,8 +180,10 @@ namespace RTC
 			// about partly received (or not received at all) data, up until
 			// `newCumulativeTsn`.
 
-			const Types::UnwrappedTsn unwrappedTsn      = this->tsnUnwrapper.Unwrap(newCumulativeTsn);
+			const Types::UnwrappedTsn unwrappedTsn = this->tsnUnwrapper.Unwrap(newCumulativeTsn);
+#if MS_LOG_DEV_LEVEL == 3
 			const Types::UnwrappedTsn prevLastCumAckTsn = this->lastCumulativeAckedTsn;
+#endif
 
 			// Old chunk already seen before?
 			if (unwrappedTsn <= this->lastCumulativeAckedTsn)
@@ -332,10 +333,10 @@ namespace RTC
 
 			if (newAckState != this->ackState)
 			{
+#if MS_LOG_DEV_LEVEL == 3
 				const auto& previousAckStateStrView = DataTracker::AckStateToString(this->ackState);
 				const auto& newAckStateStrView      = DataTracker::AckStateToString(newAckState);
 
-#if MS_LOG_DEV_LEVEL == 3
 				MS_DEBUG_DEV(
 				  "ack state changed from %.*s to %.*s due to %.*s",
 				  static_cast<int>(previousAckStateStrView.size()),

worker/src/RTC/SCTP/rx/InterleavedReassemblyStreams.cpp

@@ -1,6 +1,5 @@
 #define MS_CLASS "RTC::SCTP::InterleavedReassemblyStreams"
-// TODO: SCTP: COMMENT
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/rx/InterleavedReassemblyStreams.hpp"
 #include "Logger.hpp"

worker/src/RTC/SCTP/rx/ReassemblyQueue.cpp

@@ -1,6 +1,5 @@
 #define MS_CLASS "RTC::SCTP::ReassemblyQueue"
-// TODO: SCTP: COMMENT
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/rx/ReassemblyQueue.hpp"
 #include "Logger.hpp"

worker/src/RTC/SCTP/rx/TraditionalReassemblyStreams.cpp

@@ -1,6 +1,5 @@
 #define MS_CLASS "RTC::SCTP::TraditionalReassemblyStreams"
-// TODO: SCTP: COMMENT
-#define MS_LOG_DEV_LEVEL 3
+// #define MS_LOG_DEV_LEVEL 3
 
 #include "RTC/SCTP/rx/TraditionalReassemblyStreams.hpp"
 #include "Logger.hpp"