Skip to content

Commit 9666519

Browse files
committed
fix: review items
1 parent dd9dcf7 commit 9666519

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

.github/workflows/deploy-cloudrun.yaml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,26 +36,27 @@ jobs:
3636
runs-on: ubuntu-latest
3737
steps:
3838
- uses: actions/checkout@v4
39+
- name: Validate inputs
40+
run: |
41+
if [[ -z "${{ inputs.job-name }}" && -z "${{ inputs.service-name }}" ]]; then
42+
echo "Error: at least one of 'job-name' or 'service-name' must be provided"
43+
exit 1
44+
fi
3945
- uses: 'google-github-actions/auth@v3'
4046
with:
4147
service_account: ${{ inputs.workload-identity-service-account-mail }}
4248
workload_identity_provider: ${{ inputs.workload-identity-provider }}
43-
- name: 'Set up gcloud-cli'
44-
uses: 'google-github-actions/setup-gcloud@v3'
45-
with:
46-
version: '>= 363.0.0'
4749
- name: 'deploy cloudrun job'
4850
if: inputs.job-name != ''
4951
uses: 'google-github-actions/deploy-cloudrun@v3'
5052
with:
51-
image: ${{ inputs.registry }}${{ inputs.artifact-repository }}:${{ inputs.artifact-tag }}
53+
image: ${{ inputs.registry }}/${{ inputs.artifact-repository }}:${{ inputs.artifact-tag }}
5254
region: ${{ inputs.region }}
5355
job: ${{ inputs.job-name }}
5456
- name: 'deploy cloudrun service'
5557
if: inputs.service-name != ''
5658
uses: 'google-github-actions/deploy-cloudrun@v3'
5759
with:
58-
image: ${{ inputs.registry }}${{ inputs.artifact-repository }}:${{ inputs.artifact-tag }}
60+
image: ${{ inputs.registry }}/${{ inputs.artifact-repository }}:${{ inputs.artifact-tag }}
5961
region: ${{ inputs.region }}
6062
service: ${{ inputs.service-name }}
61-

0 commit comments

Comments
 (0)