Remove optimization to ensure next/dist is always bundled

eps1lon · eps1lon · commit 2cb4e504f2f3 · 2024-04-24T16:13:24.000+02:00
diff --git a/packages/next/webpack.config.js b/packages/next/webpack.config.js
@@ -21,12 +21,7 @@ const pagesExternals = [
 ]
 
 const appExternals = [
-  // Externalize the react-dom/server legacy implementation outside of the runtime.
-  // If users are using them and imported from 'react-dom/server' they will get the external asset bundled.
-  'next/dist/compiled/react-dom/cjs/react-dom-server-legacy.browser.development.js',
-  'next/dist/compiled/react-dom/cjs/react-dom-server-legacy.browser.production.min.js',
-  'next/dist/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.development.js',
-  'next/dist/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.production.min.js',
+  // Don't externalize next/dist/compiled/react-dom since it may require('react-dom') which would use the installed React version
 ]
 
 function makeAppAliases(reactChannel = '') {

Original file line number	Diff line number	Diff line change
`@@ -21,12 +21,7 @@ const pagesExternals = [`
`21`	`21`	`]`
`22`	`22`
`23`	`23`	`const appExternals = [`
`24`		`- // Externalize the react-dom/server legacy implementation outside of the runtime.`
`25`		`- // If users are using them and imported from 'react-dom/server' they will get the external asset bundled.`
`26`		`- 'next/dist/compiled/react-dom/cjs/react-dom-server-legacy.browser.development.js',`
`27`		`- 'next/dist/compiled/react-dom/cjs/react-dom-server-legacy.browser.production.min.js',`
`28`		`- 'next/dist/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.development.js',`
`29`		`- 'next/dist/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.production.min.js',`
	`24`	`+ // Don't externalize next/dist/compiled/react-dom since it may require('react-dom') which would use the installed React version`
`30`	`25`	`]`
`31`	`26`
`32`	`27`	`function makeAppAliases(reactChannel = '') {`