Skip to content

Commit 3d63ca4

Browse files
authored
Fix saithrift URL generation for Mellanox on internal-202411 branch sonic-net#19899
What is the motivation for this PR? The saithrift package download fails for Mellanox platforms on internal-202411 branch because the code was hardcoding bullseye as the Debian codename for all ASIC types, but Mellanox requires the actual Debian codename from the syncd container. How did you do it? Modified the condition to only use hardcoded bullseye for non-Mellanox platforms on internal-202411 For Mellanox on internal-202411, the code now retrieves the actual Debian codename via docker command This ensures the correct saithrift package URL is constructed for each platform type How did you verify/test it? local test
1 parent ae458af commit 3d63ca4

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tests/test_pretest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,8 @@ def test_update_saithrift_ptf(request, ptfhost, duthosts, enum_dut_hostname):
409409
pytest.fail("Unable to parse or recognize version format: {}".format(version))
410410

411411
# Apply special codename overrides for specific internal branches
412-
if branch_name == "internal-202411":
413-
# internal-202411 has saithrift URL hardcoded to bullseye
412+
if branch_name == "internal-202411" and asic != "mellanox":
413+
# internal-202411 has saithrift URL hardcoded to bullseye for non-mellanox platform
414414
debian_codename = "bullseye"
415415
elif (branch_name.startswith("internal-") and branch_name < "internal-202405"):
416416
# For internal branches older than 202405, use the original URL without modification

0 commit comments

Comments
 (0)