Skip to content
This repository was archived by the owner on Dec 8, 2020. It is now read-only.

Commit bf8c752

Browse files
Cleanup
1 parent f302ca0 commit bf8c752

3 files changed

Lines changed: 3 additions & 19 deletions

File tree

config/test.exs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@ config :sasl, :sasl_error_logger, false
55
config :logger, level: :warn
66

77
config :timber,
8-
api_key: "api_key",
9-
http_client: Timber.FakeHTTPClient
8+
api_key: "api_key"
109

1110
config :timber, :install,
1211
file_client: Timber.Installer.FakeFile,
1312
http_client: Timber.Installer.FakeHTTPClient,
1413
io_client: Timber.Installer.FakeIO,
15-
path_client: Timber.Installer.FakePath
14+
path_client: Timber.Installer.FakePath

lib/mix/tasks/timber/install.ex

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,6 @@ defmodule Mix.Tasks.Timber.Install do
246246
end
247247

248248
defp platform_install!(false, %{api_key: api_key} = api, _application) do
249-
:ok = check_for_http_client(api)
250-
251249
Messages.action_starting("Sending a few test logs...")
252250
|> IOHelper.write()
253251

@@ -272,18 +270,6 @@ defmodule Mix.Tasks.Timber.Install do
272270
API.wait_for_logs(api)
273271
end
274272

275-
defp check_for_http_client(api) do
276-
API.event!(api, :http_client_found)
277-
278-
case :hackney.start() do
279-
:ok -> :ok
280-
{:error, {:already_started, _name}} -> :ok
281-
other -> other
282-
end
283-
284-
:ok
285-
end
286-
287273
defp collect_feedback(api) do
288274
case IOHelper.ask("How would rate this install experience? 1 (bad) - 5 (perfect)", api) do
289275
v when v in ["4", "5"] ->

lib/mix/tasks/timber/install/timber_config_file.ex

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ defmodule Mix.Tasks.Timber.Install.TimberConfigFile do
8686
utc_log: true
8787
8888
config :timber,
89-
api_key: #{api_key_portion(api)},
90-
http_client: Timber.HTTPClients.Hackney
89+
api_key: #{api_key_portion(api)}
9190
"""
9291
end
9392

0 commit comments

Comments
 (0)