Gaurd against nil time_native values (#208)

* Gaurd against nil time_native values

* Add test for nil query_time

Author: binarylogic

lib/timber/integrations/ecto_logger.ex

@@ -80,7 +80,7 @@ defmodule Timber.Integrations.EctoLogger do
   which is then logged at the designated level.
   """
   @spec log(Ecto.LogEntry.t) :: Ecto.LogEntry.t
-  def log(%{query: query, query_time: time_native} = entry, level) do
+  def log(%{query: query, query_time: time_native} = entry, level) when is_integer(time_native) do
     case resolve_query(query, entry) do
       {:ok, query_text} ->
         # The time is given in native units which the VM determines. We have
@@ -107,6 +107,13 @@ defmodule Timber.Integrations.EctoLogger do
     end
   end
 
+  # time_native above is not an integer as expected. This is required and a violation of the
+  # type spec. Queries of this nature will be ignored.
+  def log(entry, _level) do
+    entry
+  end
+
+
   # Interestingly, the query is not necessarily a String.t, it
   # can also be a single-arity function which, given the log entry
   # as a parameter, will return a String.t

test/lib/timber/integrations/ecto_logger_test.exs

@@ -20,6 +20,16 @@ if Code.ensure_loaded?(Ecto) do
         assert log =~ "Processed SELECT * FROM table in"
         assert log =~ " @metadata "
       end
+
+      test "query_time is nil" do
+        query = "SELECT * FROM table"
+
+        log = capture_log(fn ->
+          EctoLogger.log(%{query: query, query_time: nil}, :info)
+        end)
+
+        assert log == ""
+      end
     end
   end
 end