Skip to content
This repository was archived by the owner on Dec 8, 2020. It is now read-only.

Commit 4aaa9c3

Browse files
HTTPResponseEvent no longer enforces time_ms
The `Timber.Events.HTTPResponseEvent` struct was incorrectly enforcing the `:time_ms` key. The official LogEvent specficiation does not require this key. This change removes the `:time_ms` key from the enforced keys list. Closes #226
1 parent 5fe0a50 commit 4aaa9c3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
77

88
## [Unreleased]
9+
### Fixed
10+
11+
- `Timber.Events.HTTPRepsonseEvent` no longer enforces the `:time_ms` key on
12+
the struct. This brings it in line with the specification
913

1014
## [2.5.4] - 2017-09-18
1115

lib/timber/events/http_response_event.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ defmodule Timber.Events.HTTPResponseEvent do
2525
time_ms: float
2626
}
2727

28-
@enforce_keys [:status, :time_ms]
28+
@enforce_keys [:status]
2929
defstruct [
3030
:body,
3131
:direction,

0 commit comments

Comments
 (0)