Add menu option for external_url if present - #2560
Merged
Merged
Conversation
|
Can one of the admins verify this patch? |
dbkr
requested changes
Nov 8, 2016
| }, | ||
|
|
||
| onPermalinkClick: function() { | ||
| onLinkClick: function() { |
Member
There was a problem hiding this comment.
If you're re-using this, I'd call it 'closeMenu'
| externalURLButton = ( | ||
| <div className="mx_MessageContextMenu_field"> | ||
| <a target="_blank" href={ this.props.mxEvent.event.content.external_url } | ||
| onClick={ this.onLinkClick }>Source URL</a> |
Member
There was a problem hiding this comment.
rel="noopener" please: https://mathiasbynens.github.io/rel-noopener/
Member
Author
There was a problem hiding this comment.
I'll add it to both, just because it makes me feel better.
| <div className="mx_MessageContextMenu_field"> | ||
| <a href={ "https://matrix.to/#/" + this.props.mxEvent.getRoomId() +"/"+ this.props.mxEvent.getId() } | ||
| target="_blank" onClick={ this.onPermalinkClick }>Permalink</a> | ||
| target="_blank" onClick={ this.onLinkClick }>Permalink</a> |
Member
There was a problem hiding this comment.
We should also add rel="noopener" here, which we seem to have forgotten (although presumably we sort of trust matrix.to)
Member
Author
There was a problem hiding this comment.
Didn't realise that was a thing. Neat.
dbkr
approved these changes
Nov 8, 2016
t3chguy
pushed a commit
that referenced
this pull request
Mar 25, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.