Electron app (take 3) - #2535
Merged
Merged
Conversation
From #2511 but with just the actual electron changes
Closed
richvdh
reviewed
Nov 3, 2016
richvdh
left a comment
richvdh
left a comment
Member
There was a problem hiding this comment.
looks plausible, without not knowing anything about electron. Would like to have another look once the other PRs land
| // @flow | ||
|
|
||
| /* | ||
| Copyright 2016 Aviral Dasgupta and OpenMarket Ltd |
| } | ||
| ]; | ||
|
|
||
| if (process.platform === 'darwin') { |
| let Platform = WebPlatform; | ||
| let Platform = null; | ||
|
|
||
| if (window && window.process && window.process && window.process.type === 'renderer') { |
Member
There was a problem hiding this comment.
can we make this happen at build time (and make the Web/ElectronPlatform import conditional) so as to avoid shipping electron in the web bundle (assuming that's what happens)?
Member
Author
|
ok - other PRs now landed, so ptal :) |
Member
Author
|
(lgtm-ed out-of-band) |
t3chguy
pushed a commit
that referenced
this pull request
Mar 25, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #2511
This is just the changes to actually make the electron app (minus supporting things like factoring various functionality out to Platform classes).