Skip to content

Add Notification support to the Web Platform - #2533

Merged
dbkr merged 2 commits into
developfrom
dbkr/platform_notification
Nov 2, 2016
Merged

Add Notification support to the Web Platform#2533
dbkr merged 2 commits into
developfrom
dbkr/platform_notification

Conversation

@dbkr

@dbkr dbkr commented Nov 2, 2016

Copy link
Copy Markdown
Member

Except display notification which was already accidentally included in a
previous PR

Except display notification which was already accidentally included in a
previous PR

@richvdh richvdh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Comment thread src/vector/platform/WebPlatform.js Outdated
* notifications, otherwise false.
*/
supportsNotifications() : boolean {
return true;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to return Boolean(global.Notification) ?

@richvdh richvdh assigned dbkr and unassigned richvdh Nov 2, 2016
Only if the browser has the Notification API
@dbkr
dbkr merged commit 18504ca into develop Nov 2, 2016
@t3chguy
t3chguy deleted the dbkr/platform_notification branch May 12, 2022 08:55
t3chguy pushed a commit that referenced this pull request Mar 25, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants