Switch to yarn for dependency management - #9132
Merged
Merged
Conversation
The npm lock file was imported into yarn. A yarn install pass was then run to double-check the lock file for sanity.
We did not previously commit lock files for the Electron app, so there is no correct copy to import from. For this directory, I created a fresh yarn lock file using yarn install.
Most `npm` operations are replaced with `yarn`, which generally has better behavior. However, steps like publish that write to the NPM registry are left to `npm`, which currently handles these tasks best.
turt2live
self-requested a review
March 12, 2019 18:27
turt2live
approved these changes
Mar 12, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most
npmoperations are replaced withyarn, which generally has betterbehavior. However, steps like publish that write to the NPM registry are left to
npm, which currently handles these tasks best.Part of #7756
Previously reviewed portion for JS SDK: matrix-org/matrix-js-sdk#856
Under review portion for React SDK: matrix-org/matrix-react-sdk#2773