Change olm dependency to normal dep - #9068
Merged
Merged
Conversation
It would be nice if it were actually an optional dependency and you could just not install olm and get a Riot without olm, but you can't: what you get is a broken Riot, so having it as an optional dep isn't helping anyone. Also whatever other package-lock changes npm has decided are necessary today.
jryans
approved these changes
Mar 6, 2019
jryans
left a comment
jryans
left a comment
Collaborator
There was a problem hiding this comment.
I had been thinking to do this as well. Thanks! 😁
| "optionalDependencies": { | ||
| "olm": "https://matrix.org/packages/npm/olm/olm-3.1.0-pre1.tgz" | ||
| }, | ||
| "optionalDependencies": {}, |
Collaborator
There was a problem hiding this comment.
Maybe remove the optionalDep key entirely, now that it's empty?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice if it were actually an optional dependency and you
could just not install olm and get a Riot without olm, but you can't:
what you get is a broken Riot, so having it as an optional dep isn't
helping anyone.
Also whatever other package-lock changes npm has decided are
necessary today.