Correct the copying of e-mail addresses in the electron app - #8124
Merged
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/electron-mailto
branch
from
January 15, 2019 08:37
d7e7180 to
8c895cd
Compare
Collaborator
|
(It is a bit surprising that this PR shows my develop commit for |
Member
|
That change apparently hasn't made it to experimental I guess :( I'm generally fine with ignoring the problem though and reviewing the actual changes at hand |
Member
Author
|
I/someone can rebase if needs be. |
turt2live
approved these changes
Jan 15, 2019
Member
Author
|
Does it need rebasing to get out that other commit or not? |
Member
|
I don't think it does. It's a small change that should be on experimental anyways: this is just the vessel to get it there |
Collaborator
|
(The actual textual change made in the other commit is already present on experimental. It was just made via different commits for develop and experimental, which seems to be confusing things. Should be safe to ignore.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7937
Changes the labels all the match casing of Chrome.
Fixes a small typo in a comment.
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com