Translations! - #4035
Merged
Merged
Conversation
Use async/await consistently rather than flipping between that and callbacks, s/var/let/, indenting
as they don't seem to be necessary
If we're defaulting this it should really be by the component itself or with the other defaukts in SdkConfig, but we've decided to leave out support for reading languages from the config file as it's only useful for a Riot admin to restrict the choice of languages available to users which is of debateable use.
to use react-sdk wrapper function, rather than using counterpart directly.
We now use stock counterpart, but indirectly via react-sdk so no need to depend on it directly.
and remove extCounterpart which is unnecessary now we just use a single counterpart instance
We now get multiple languages from the browser as there may be a whole preference list
Change array.push guideline to not using _t at class-load time which was probably the actual problem. Update guidelines to include punctuation.
As it is in English and not German
It's even less use in a comment
* Move language files to strings/ subdir to be consistent with react-sdk * Only copy static list of languages (to avoid including languages that are only a few percent translated) * Make copy-res script work with watch mode * Other general cleanups like only write each language file once, rather than n times.
Member
|
lgtm other than "ewwwwww" at en_en being a 1:1 lookup, and the dropdown still being a bit ugly in settings (but i can fix that post-merge) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged from #3636