make electron send email validation URLs with a nextlink of riot.im - #2808
Merged
Conversation
…ather than file:///
Member
Author
|
twinned with matrix-org/matrix-react-sdk#601 |
richvdh
approved these changes
Dec 24, 2016
| window.location.pathname + | ||
| '#/register'; | ||
| if (window.location.protocol === "file:") { | ||
| return 'https://riot.im/app/#/register'; |
Member
There was a problem hiding this comment.
This really ought to be configurable. Can we make it pull it from the config file?
Member
Author
There was a problem hiding this comment.
yes, we can. but riot.im/app is hardcoded elsewhere right now, and we'll have to tidy this up later; i want to ship this.
t3chguy
pushed a commit
that referenced
this pull request
Mar 25, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rather than file:///, which crashes browsers in horrible ways c.f. https://twitter.com/agumonkey/status/812060535567040512. This was already worked around on sydent.