Deprecate legacy packet access instructions #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
force-pushed
the
legacy
branch
3 times, most recently
from
8762573 to
9cd25f8
Compare
The BPF ISA specification does not define them, and just says "these instructions are deprecated and should no longer be used". To comply with that, this PR disables support for legacy packet access instructions by default. If some other project depends on them, options.legacy can be set to true. Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
dthaler
added a commit
to dthaler/ebpf-for-windows
that referenced
this pull request
Feb 4, 2024
Changes to match latest draft-ietf-bpf-isa Also correct legacy packet instruction lines to show that PREVAIL does support them. vbpf/prevail#577 will update the verifier so make such support a platform specific property but that hasn't been merged yet so this PR reflects current state. Signed-off-by: Dave Thaler <[email protected]>
dthaler
added a commit
to dthaler/ebpf-for-windows
that referenced
this pull request
Feb 4, 2024
Changes to match latest draft-ietf-bpf-isa Also correct legacy packet instruction lines to show that PREVAIL does support them. vbpf/prevail#577 will update the verifier so make such support a platform specific property but that hasn't been merged yet so this PR reflects current state. Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
github-merge-queue bot
pushed a commit
to microsoft/ebpf-for-windows
that referenced
this pull request
Feb 9, 2024
Changes to match latest draft-ietf-bpf-isa Also correct legacy packet instruction lines to show that PREVAIL does support them. vbpf/prevail#577 will update the verifier so make such support a platform specific property but that hasn't been merged yet so this PR reflects current state. Signed-off-by: Dave Thaler <[email protected]>
elazarg
approved these changes
Feb 15, 2024
Collaborator
elazarg
left a comment
elazarg
left a comment
There was a problem hiding this comment.
Just a couple of grammatical comments
Contributor
Author
|
@elazarg I accepted grammar suggestions |
Signed-off-by: Dave Thaler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BPF ISA specification does not define them, and just says "these instructions are deprecated and should no longer be used". To comply with that, this PR lets the platform specify whether they are supported. (ebpf-for-windows for example doesn't support them so it's important to fail verification.)
This PR also adds some YAML tests for the deprecated packet instructions.