Expand wait condition time for slave selection test #2604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2604 +/- ##
============================================
+ Coverage 72.21% 72.26% +0.04%
============================================
Files 127 127
Lines 70777 70820 +43
============================================
+ Hits 51114 51179 +65
+ Misses 19663 19641 -22 🚀 New features to boost your workflow:
|
enjoy-binbin
approved these changes
Sep 12, 2025
enjoy-binbin
changed the title
Member
|
please fix the DCO |
Signed-off-by: Vitali Arbuzov <[email protected]>
vitarb
force-pushed
the
codex/fix-ci-test-failure-with-valgrind
branch
from
ed1190f to
449956e
Compare
Contributor
Author
Fixed ✅ |
hpatro
approved these changes
Sep 12, 2025
sarthakaggarwal97
approved these changes
Sep 12, 2025
Co-authored-by: Harkrishn Patro <[email protected]> Signed-off-by: Binbin <[email protected]>
enjoy-binbin
pushed a commit
that referenced
this pull request
Sep 16, 2025
…2612) With #2604 merged, the `Node #10 should eventually replicate node #5` started passing successfully with valgrind, but I guess we are seeing a new daily failure from a `New Master down consecutively` test that runs shortly after. Signed-off-by: Sarthak Aggarwal <[email protected]>
rjd15372
pushed a commit
to rjd15372/valkey
that referenced
this pull request
Sep 19, 2025
## Summary - extend replication wait time in `slave-selection` test ``` *** [err]: Node valkey-io#10 should eventually replicate node valkey-io#5 in tests/unit/cluster/slave-selection.tcl valkey-io#10 didn't became slave of valkey-io#5 ``` ## Testing - `./runtest --single unit/cluster/slave-selection` - `./runtest --single unit/cluster/slave-selection --valgrind` Signed-off-by: Vitali Arbuzov <[email protected]> Signed-off-by: Binbin <[email protected]> Co-authored-by: Binbin <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]>
rjd15372
pushed a commit
to rjd15372/valkey
that referenced
this pull request
Sep 19, 2025
…alkey-io#2612) With valkey-io#2604 merged, the `Node valkey-io#10 should eventually replicate node valkey-io#5` started passing successfully with valgrind, but I guess we are seeing a new daily failure from a `New Master down consecutively` test that runs shortly after. Signed-off-by: Sarthak Aggarwal <[email protected]>
rjd15372
pushed a commit
that referenced
this pull request
Sep 23, 2025
## Summary - extend replication wait time in `slave-selection` test ``` *** [err]: Node #10 should eventually replicate node #5 in tests/unit/cluster/slave-selection.tcl #10 didn't became slave of #5 ``` ## Testing - `./runtest --single unit/cluster/slave-selection` - `./runtest --single unit/cluster/slave-selection --valgrind` Signed-off-by: Vitali Arbuzov <[email protected]> Signed-off-by: Binbin <[email protected]> Co-authored-by: Binbin <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]>
rjd15372
pushed a commit
that referenced
this pull request
Sep 23, 2025
…2612) With #2604 merged, the `Node #10 should eventually replicate node #5` started passing successfully with valgrind, but I guess we are seeing a new daily failure from a `New Master down consecutively` test that runs shortly after. Signed-off-by: Sarthak Aggarwal <[email protected]>
Contributor
|
@vitarb @enjoy-binbin looks like the test failed again recently 2 days back: https://github.com/valkey-io/valkey/actions/runs/18081789287/job/51446150777#step:6:12830 Should we further increase the wait time? |
Contributor
|
Also 3 days back, https://github.com/valkey-io/valkey/actions/runs/18066680642/job/51410287680#step:6:11341. All with valgrind enabled. |
hpatro
added a commit
to hpatro/valkey
that referenced
this pull request
Oct 3, 2025
## Summary - extend replication wait time in `slave-selection` test ``` *** [err]: Node valkey-io#10 should eventually replicate node valkey-io#5 in tests/unit/cluster/slave-selection.tcl valkey-io#10 didn't became slave of valkey-io#5 ``` ## Testing - `./runtest --single unit/cluster/slave-selection` - `./runtest --single unit/cluster/slave-selection --valgrind` Signed-off-by: Vitali Arbuzov <[email protected]> Signed-off-by: Binbin <[email protected]> Co-authored-by: Binbin <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]> Signed-off-by: Harkrishn Patro <[email protected]>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Oct 3, 2025
…alkey-io#2612) With valkey-io#2604 merged, the `Node valkey-io#10 should eventually replicate node valkey-io#5` started passing successfully with valgrind, but I guess we are seeing a new daily failure from a `New Master down consecutively` test that runs shortly after. Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Harkrishn Patro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
slave-selectiontest, this should address failures such as https://github.com/valkey-io/valkey/actions/runs/17567668742/job/49897703622Testing
./runtest --single unit/cluster/slave-selection./runtest --single unit/cluster/slave-selection --valgrind