Skip to content

Fix assumptions that pthread functions set errno #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

Fix assumptions that pthread functions set errno #2526

merged 1 commit into from
Aug 20, 2025

Conversation

@TedLyngmo
Copy link
Contributor

@TedLyngmo TedLyngmo commented Aug 20, 2025

pthread functions return the error instead of setting errno.

Fixes #2525

@TedLyngmo
Fix assumptions that pthread functions set errno
169a8cb 
pthread functions return the error instead of setting errno.

Fixes valkey-io#2525

Signed-off-by: Ted Lyngmo <[email protected]>
@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.01%. Comparing base (23112fa) to head (169a8cb).
⚠️ Report is 2 commits behind head on unstable.

Files with missing lines Patch % Lines
src/bio.c 66.66% 2 Missing ⚠️
src/io_threads.c 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #2526      +/-   ##
============================================
- Coverage     72.03%   72.01%   -0.02%     
============================================
  Files           126      126              
  Lines         70490    70493       +3     
============================================
- Hits          50774    50765       -9     
- Misses        19716    19728      +12
Files with missing lines Coverage Δ
src/io_threads.c 35.20% <66.66%> (+0.20%) ⬆️
src/bio.c 85.13% <66.66%> (+0.20%) ⬆️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zuiderkwast
zuiderkwast approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Thanks.

I knew this, but I hadn't noticed this programming error until now.

@zuiderkwast zuiderkwast merged commit c6c91d1 into valkey-io:unstable Aug 20, 2025
53 checks passed
@zuiderkwast zuiderkwast moved this to To be backported in Valkey 7.2 Aug 20, 2025
@zuiderkwast zuiderkwast moved this to To be backported in Valkey 8.0 Aug 20, 2025
@zuiderkwast zuiderkwast moved this to To be backported in Valkey 8.1 Aug 20, 2025
@TedLyngmo TedLyngmo deleted the pthread_errno branch August 20, 2025 21:02
@zuiderkwast zuiderkwast moved this from To be backported to 8.0.5 (to be released) in Valkey 8.0 Aug 21, 2025
zuiderkwast pushed a commit to vitarb/valkey that referenced this pull request Aug 21, 2025
@TedLyngmo @zuiderkwast
Fix assumptions that pthread functions set errno (valkey-io#2526)
6dc4112 
pthread functions return the error instead of setting errno.

Fixes valkey-io#2525

Signed-off-by: Ted Lyngmo <[email protected]>
@zuiderkwast zuiderkwast mentioned this pull request Aug 21, 2025
Merged
zuiderkwast pushed a commit that referenced this pull request Aug 22, 2025
@TedLyngmo @zuiderkwast
Fix assumptions that pthread functions set errno (#2526)
ca45554 
pthread functions return the error instead of setting errno.

Fixes #2525

Signed-off-by: Ted Lyngmo <[email protected]>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/valkey that referenced this pull request Sep 16, 2025
@TedLyngmo @sarthakaggarwal97
Fix assumptions that pthread functions set errno (valkey-io#2526)
b4666f5 
pthread functions return the error instead of setting errno.

Fixes valkey-io#2525

Signed-off-by: Ted Lyngmo <[email protected]>
rjd15372 pushed a commit to rjd15372/valkey that referenced this pull request Sep 19, 2025
@TedLyngmo @rjd15372
Fix assumptions that pthread functions set errno (valkey-io#2526)
4e13fdc 
pthread functions return the error instead of setting errno.

Fixes valkey-io#2525

Signed-off-by: Ted Lyngmo <[email protected]>
rjd15372 pushed a commit that referenced this pull request Sep 23, 2025
@TedLyngmo @rjd15372
Fix assumptions that pthread functions set errno (#2526)
1dfb52e 
pthread functions return the error instead of setting errno.

Fixes #2525

Signed-off-by: Ted Lyngmo <[email protected]>
@ranshid ranshid moved this from To be backported to In Progress in Valkey 8.1 Sep 30, 2025
ranshid pushed a commit to ranshid/valkey that referenced this pull request Sep 30, 2025
@TedLyngmo @ranshid
Fix assumptions that pthread functions set errno (valkey-io#2526)
5b526a4 
pthread functions return the error instead of setting errno.

Fixes valkey-io#2525

Signed-off-by: Ted Lyngmo <[email protected]>
ranshid pushed a commit to ranshid/valkey that referenced this pull request Sep 30, 2025
@TedLyngmo @ranshid
Fix assumptions that pthread functions set errno (valkey-io#2526)
0a2d20b 
pthread functions return the error instead of setting errno.

Fixes valkey-io#2525

Signed-off-by: Ted Lyngmo <[email protected]>
@ranshid ranshid moved this from In Progress to 8.1.4 in Valkey 8.1 Sep 30, 2025
@ranshid ranshid moved this from 8.1.4 to To be backported in Valkey 8.1 Sep 30, 2025
@zuiderkwast zuiderkwast moved this from To be backported to 7.2.11 (to be released) in Valkey 7.2 Sep 30, 2025
@zuiderkwast zuiderkwast moved this from 7.2.11 (to be released) to To be backported in Valkey 7.2 Sep 30, 2025
@zuiderkwast zuiderkwast moved this from To be backported to 7.2.11 (to be released) in Valkey 7.2 Sep 30, 2025
zuiderkwast pushed a commit to zuiderkwast/placeholderkv that referenced this pull request Sep 30, 2025
@TedLyngmo @zuiderkwast
Fix assumptions that pthread functions set errno (valkey-io#2526)
4065be1 
pthread functions return the error instead of setting errno.

Fixes valkey-io#2525

Signed-off-by: Ted Lyngmo <[email protected]>
zuiderkwast pushed a commit that referenced this pull request Oct 1, 2025
@TedLyngmo @zuiderkwast
Fix assumptions that pthread functions set errno (#2526)
f0da93e 
pthread functions return the error instead of setting errno.

Fixes #2525

Signed-off-by: Ted Lyngmo <[email protected]>
zuiderkwast pushed a commit that referenced this pull request Oct 1, 2025
@TedLyngmo @zuiderkwast
Fix assumptions that pthread functions set errno (#2526)
a3d7f86 
pthread functions return the error instead of setting errno.

Fixes #2525

Signed-off-by: Ted Lyngmo <[email protected]>
@zuiderkwast zuiderkwast moved this from To be backported to 8.1.4 in Valkey 8.1 Oct 1, 2025
hpatro pushed a commit to hpatro/valkey that referenced this pull request Oct 3, 2025
@TedLyngmo @hpatro
Fix assumptions that pthread functions set errno (valkey-io#2526)
c42292a 
pthread functions return the error instead of setting errno.

Fixes valkey-io#2525

Signed-off-by: Ted Lyngmo <[email protected]>
Signed-off-by: Harkrishn Patro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees

@TedLyngmo TedLyngmo

Labels

None yet

Projects

Valkey 7.2
Status: 7.2.11
Valkey 8.0
Status: 8.0.5
Valkey 8.1
Status: 8.1.4

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] pthread functions are expected to set errno in some places

2 participants

@TedLyngmo @zuiderkwast