Skip to content

Add packet-drop to fix the new flaky failover test #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

Add packet-drop to fix the new flaky failover test #2196

merged 2 commits into from
Jun 11, 2025

Conversation

@enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Jun 11, 2025 •
edited
Loading

The new test was added in #2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

@enjoy-binbin enjoy-binbin added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label Jun 11, 2025
@enjoy-binbin enjoy-binbin mentioned this pull request Jun 11, 2025
Merged
@enjoy-binbin
Copy link
Member Author

enjoy-binbin commented Jun 11, 2025

https://github.com/valkey-io/valkey/actions/runs/15576081823
valgrind ci

@codecov
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.39%. Comparing base (c41ffc3) to head (2b99196).
Report is 3 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #2196      +/-   ##
============================================
- Coverage     71.50%   71.39%   -0.12%     
============================================
  Files           122      122              
  Lines         66493    66493              
============================================
- Hits          47548    47473      -75     
- Misses        18945    19020      +75

see 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enjoy-binbin enjoy-binbin changed the title Try to fix the flaky failover test Add packet-drop to fix the new flaky failover test Jun 11, 2025
@enjoy-binbin
Copy link
Member Author

enjoy-binbin commented Jun 11, 2025

I see both tests are passed, so i think we are good to go.

[ok]: Replica can update the config epoch when trigger the failover - automatic (16813 ms)
=== (external:skip cluster) Starting server on 127.0.0.1:21689 ok
=== (external:skip cluster) Starting server on 127.0.0.1:21690 ok
=== (external:skip cluster) Starting server on 127.0.0.1:21691 ok
=== (external:skip cluster) Starting server on 127.0.0.1:21692 ok
[ok]: Replica can update the config epoch when trigger the failover - manual (8716 ms)

@enjoy-binbin enjoy-binbin requested a review from hpatro June 11, 2025 06:06
@enjoy-binbin enjoy-binbin merged commit 2019337 into valkey-io:unstable Jun 11, 2025
97 of 100 checks passed
@enjoy-binbin enjoy-binbin deleted the fix_flaky_test branch June 11, 2025 09:01
hpatro pushed a commit to hpatro/valkey that referenced this pull request Jun 11, 2025
@enjoy-binbin @hpatro
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
00bfdef 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
@hpatro hpatro moved this to To be backported in Valkey 8.1 Jun 11, 2025
@hpatro hpatro moved this to To be backported in Valkey 8.0 Jun 11, 2025
@hpatro hpatro moved this to To be backported in Valkey 7.2 Jun 11, 2025
hpatro pushed a commit that referenced this pull request Jun 11, 2025
@enjoy-binbin @hpatro
Add packet-drop to fix the new flaky failover test (#2196)
51f8cd5 
The new test was added in #2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
@hpatro hpatro moved this from To be backported to 8.1.2 in Valkey 8.1 Jun 11, 2025
chzhoo pushed a commit to chzhoo/valkey that referenced this pull request Jun 12, 2025
@enjoy-binbin @chzhoo
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
600252e 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: chzhoo <[email protected]>
vitarb pushed a commit to vitarb/valkey that referenced this pull request Jun 12, 2025
@enjoy-binbin @vitarb
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
8528705 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 2019337)
@vitarb vitarb mentioned this pull request Jun 13, 2025
Merged
vitarb pushed a commit to vitarb/valkey that referenced this pull request Jun 13, 2025
@enjoy-binbin @vitarb
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
0ef3dc3 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 2019337)
shanwan1 pushed a commit to shanwan1/valkey that referenced this pull request Jun 13, 2025
@enjoy-binbin
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
29901c7 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: shanwan1 <[email protected]>
@ranshid ranshid removed this from Valkey 7.2 Jun 18, 2025
ranshid pushed a commit to ranshid/valkey that referenced this pull request Jun 18, 2025
@enjoy-binbin @ranshid
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
91a7a73 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
zuiderkwast pushed a commit to vitarb/valkey that referenced this pull request Aug 15, 2025
@enjoy-binbin @zuiderkwast
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
102bb85 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 2019337)
zuiderkwast pushed a commit to vitarb/valkey that referenced this pull request Aug 15, 2025
@enjoy-binbin @zuiderkwast
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
b64e086 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 2019337)
Signed-off-by: Viktor Söderqvist <[email protected]>
@zuiderkwast zuiderkwast moved this from To be backported to 8.0.5 in Valkey 8.0 Aug 18, 2025
zuiderkwast pushed a commit to vitarb/valkey that referenced this pull request Aug 21, 2025
@enjoy-binbin @zuiderkwast
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
7aaea89 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 2019337)
Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast pushed a commit that referenced this pull request Aug 22, 2025
@enjoy-binbin @zuiderkwast
Add packet-drop to fix the new flaky failover test (#2196)
092c965 
The new test was added in #2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 2019337)
Signed-off-by: Viktor Söderqvist <[email protected]>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/valkey that referenced this pull request Sep 16, 2025
@enjoy-binbin @sarthakaggarwal97
Add packet-drop to fix the new flaky failover test (valkey-io#2196)
f6f95e3 
The new test was added in valkey-io#2178, obviously there may be
pending reads in the connection, so there may be a race
in the DROP-CLUSTER-PACKET-FILTER part causing the test
to fail. Add CLOSE-CLUSTER-LINK-ON-PACKET-DROP to ensure
that the replica does not process the packet.

Signed-off-by: Binbin <[email protected]>
(cherry picked from commit 2019337)
Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

@hpatro hpatro Awaiting requested review from hpatro

Assignees

No one assigned

Labels

run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)

Projects

Valkey 8.0
Status: 8.0.5
Valkey 8.1
Status: 8.1.2

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enjoy-binbin @zuiderkwast